Simple javascript loop doesnt work as intended

Question

I want my trigger to activate every 2 seconds, but each time with my value of i. Like first 3 seconds trigger .slide1, after another 3 seconds .slide2 etc...

Here my code :

    setInterval(function () {
     for ( var i = 0; i < 5; i++ ) {
        $('.slide'+ i).trigger('click');
    }   
}, 3000)

After 3 seconds it immediately trigger my .slide4 and i was wondering why ?

Every time the function is called you tell it to trigger the click on all your slides. — Coda17
– Coda17, Commented Jun 3, 2014 at 13:09
After three seconds, your for loop is running in it's entirety, so all of your slides are triggering the click — xJoshWalker
– xJoshWalker, Commented Jun 3, 2014 at 13:09
Btw. this is a regular JavaScript for loop, not a jQuery loop (e.g. $.each()) - the thread subject is somewhat confusing. — UweB
– UweB, Commented Jun 3, 2014 at 13:12

Gabriele Petrioli · Accepted Answer · 2014-06-03 13:16:50Z

2

Try

var slide = 0;
setInterval(function () {
        $('.slide'+ (slide++ % 5)).trigger('click');
}, 3000);

The problem with your code is that each time the interval function is called, you execute the loop and trigger the click event for all the slides.

edited Jun 3, 2014 at 13:16

answered Jun 3, 2014 at 13:09

Gabriele Petrioli

197k35 gold badges275 silver badges331 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Oliboy50 Over a year ago

Could you explain why you used modulo here ?

Gabriele Petrioli Over a year ago

@Oliboy50 this way you can keep the counter (slider variable) between 0 and the number you divide. In this case 0-4.

Oliboy50 Over a year ago

Clever. But are you sure that there will be no issue if user stay on this page a long long long time, cause of the slide integer limit value ?

Gabriele Petrioli Over a year ago

@Oliboy50 the max integer is 9007199254740992. To reach that by incrementing every 3 seconds, takes approximately (if my calculations are correct) 856 million years ;)

Oliboy50 Over a year ago

@GabyakaG.Petrioli Thanks for pointing the max integer value ;)

Collectives™ on Stack Overflow

Simple javascript loop doesnt work as intended

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related