How to comma-separate a set of strings without the final comma

Question

int rowPosition = 0;
string WorkerName = "";
DataTable dtAllotedManpower = new DataTable();
dtAllotedManpower.Columns.Add("WorkerName");
foreach (GridViewRow row in GridViewTotalManpower.Rows)
{
    if (row.RowType == DataControlRowType.DataRow)
    {
        DataRow drAllotedManpower = dtAllotedManpower.NewRow();
        CheckBox chkChild = (CheckBox)GridViewTotalManpower.Rows[rowPosition].FindControl("chkChild");
        if (chkChild.Checked == true)
        {
            WorkerName = Convert.ToString(GridViewTotalManpower.DataKeys[rowPosition]["WorkerName"].ToString()) + "," + WorkerName;

        }
        rowPosition++;
    }
    hidfWorker.Value = WorkerName;

I have Written the following piece of code. My hidden field values are coming like this

"HARSH,RIMA,"

But i want the value "HARSH,RIMA" (without ',' after the last word). how to construct the code for that ? . there will be no 'comma' after last word .

Simon Whitehead · Accepted Answer · 2014-06-05 06:27:05Z

12

Add them to a collection then use string.Join:

var list = new List<string>();

foreach (GridViewRow row in GridViewTotalManpower.Rows) {
    // ...other code here...
    list.Add(Convert.ToString(GridViewTotalManpower.DataKeys[rowPosition]["WorkerName"].ToString()));
}

 hidfWorker.Value = string.Join(", ", list);

answered Jun 5, 2014 at 6:27

Simon Whitehead

65.3k10 gold badges120 silver badges140 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Davide Lettieri Over a year ago

this is the best way to do this

schei1 · Accepted Answer · 2014-06-05 06:24:47Z

2

You can use string.TrimEnd()

hidfWorker.Value = WorkerName.TrimEnd(',');

This will remove the last comma from the string.

answered Jun 5, 2014 at 6:24

schei1

2,4871 gold badge20 silver badges22 bronze badges

2 Comments

schei1 Over a year ago

@SimonWhitehead: Indeed. You do have the proper solution :-)

Arijit Mukherjee Over a year ago

Santanu also refer the answer by @Simon

Dhaval Patel · Accepted Answer · 2014-06-05 06:30:44Z

1

you can use the substring method

hidfWorker.Value=WorkerName.Substring(0,WorkerName.Length-1);

answered Jun 5, 2014 at 6:30

Dhaval Patel

7,6116 gold badges43 silver badges72 bronze badges

Comments

Mukesh Modhvadiya · Accepted Answer · 2014-06-05 06:37:11Z

1

Use StringBuilder instead of string if you are frequently changing the string like in loops, because when you use string it will create new string object every time you changes it,

StringBuilder workerName = new StringBuilder();

And in your loop

workerName.Append(Convert.ToString(GridViewTotalManpower.DataKeys[rowPosition]["WorkerName"].ToString()) + ",");

Then trim last ',' character using TrimEnd method

hidfWorker.Value = workerName.ToString().TrimEnd(',');

Hope this helps.

answered Jun 5, 2014 at 6:37

Mukesh Modhvadiya

2,1982 gold badges28 silver badges32 bronze badges

Collectives™ on Stack Overflow

How to comma-separate a set of strings without the final comma

4 Answers 4

1 Comment

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related