Editing existing entries in Django forms

Question

My problem is similar to how to edit model data using django forms, but I'm not able to solve it. I would like to get an form with prefielled fields and to allow user to edit them. I believe my problem is in views.py file, but unfrotuntely I'm not able to solve it.

models.py

from django.db import models

class Item(models.Model):
    product = models.CharField(max_length=150)
    quantity = models.DecimalField(max_digits=8, decimal_places=3)
    price = models.DecimalField(max_digits=7, decimal_places=2)
    purchase_date = models.DateTimeField()
    warranty = models.DecimalField(max_digits=4, decimal_places=1)
    comment = models.TextField()

forms.py

from django import forms 
from items.models import Item

class EditItemForm(forms.ModelForm):
    class Meta:
        model = Item
        fields = ('product','quantity', 'price', 'purchase_date', 'warranty', 'comment')

urls.py

from django.conf.urls import patterns, include, url 

urlpatterns = patterns('',
    url(r'^show_all/$', 'items.views.items'),
    url(r'^(?P<item_id>\d+)/$', 'items.views.item'),
    url(r'^edit/(?P<item_id>\d+)/$', 'items.views.edit'),
)

edit.html

<form action="/items/edit/" method="post" class="form horizontal well">{% csrf_token %}
    {{ form.as_p }}
    <imput type="submit" class="btn btn-inverse" value="Aktualizuj">
</form>

views.py

from django.shortcuts import render_to_response
from django.http import HttpResponseRedirect
from items.models import Item
from decimal import Decimal
from django.core.context_processors import csrf
from items.forms import EditItemForm
def edit(request):
    if request.method == 'POST':
        form = EditItemForm(request.POST, instance=request.item)
        if form.is_valid():
            form.save()
            return HttpResponseRedirect('/items/show_all/')

    else:
        form = EditItemForm(instance=item)

    args = {}
    args.update(csrf(request))
    args['form'] = form

    return render_to_response('edit.html', args)

Above code is resulting this message:

TypeError at /items/edit/1/

edit() got an unexpected keyword argument 'item_id'

Can you please help me?

Django 1.6, Python 3.4

Daniel Roseman · Accepted Answer · 2014-06-08 19:12:37Z

5

You've imagined an attribute called request.item. There's no such thing. You need to get the item from the database, via the ID passed into the function as alecxe showed.

def edit(request, item_id):
    item = Item.objects.get(pk=item_id)
    if request.method == 'POST':
        form = EditItemForm(request.POST, instance=item)

answered Jun 8, 2014 at 19:12

Daniel Roseman

602k68 gold badges911 silver badges924 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Marek H. Over a year ago

There is one remaining problem. Because of the fact that I'm passing "return render_to_response('edit.html', args)" my edit.html file is not able to be populated by {{ item.id }} in <form action="/items/edit/{{ item.id }}/" (...) . How to get this id and put it to html file?

Daniel Roseman Over a year ago

Well, that should be obvious: add the item (or even better, the id) into args. But actually, you don't even need to do that: you're posting to the current URL, so you can just do action=".".

alecxe · Accepted Answer · 2014-06-08 18:16:22Z

1

edit() view should allow a keyword argument item_id:

def edit(request, item_id=None):
    if request.method == 'POST':
        ...

answered Jun 8, 2014 at 18:16

alecxe

476k127 gold badges1.1k silver badges1.2k bronze badges

3 Comments

Marek H. Over a year ago

Yes, this solves this warning. But it still doesnt work. I believe there is problem with "instance". Is there any expected flow of those arguments?

alecxe Over a year ago

@user3093247 ok, what is happening?

Marek H. Over a year ago

I believe there is problem with "instance". Is there any expected flow of those arguments?

Collectives™ on Stack Overflow

Editing existing entries in Django forms

2 Answers 2

2 Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related