ScrollView - Adding dynamic rows from inflated xml layout

Question

I currently have a scrollview which I am adding rows to by inflating another xml layout. This is all working as it should and the row are all appearing correctly.

The issue I am having is that I am not sure how I can detect which button has been selected.

I have shown some example code for 1 on by buttons, simply put when this button is selected it toggles between 2 images. However, whenever I press the button it always automatially toggles the bottom rows button rather than the row in which the button has been selected.

Is there a way this can be implemented whilst still inflating a view to be used as a row (I do not want to dynamially create the rows, as this gets very messy)?

ScrollView scrollWeapons = (ScrollView)findViewById(R.id.scrollWeapons);
LinearLayout ll = new LinearLayout(this);
ll.setOrientation(LinearLayout.VERTICAL);
int i = 0;

for(final Weapon w : Game.Weapons)
{
    View view = new View(this);
    LayoutInflater inflater = (LayoutInflater) getApplicationContext().getSystemService(Context.LAYOUT_INFLATER_SERVICE);
    view = inflater.inflate(R.layout.menuweapons_row, null);

    btnSelected = (ImageButton)view.findViewById(R.id.btnSelected);
    btnSelected.setId(i);
    btnSelected.setOnClickListener(new OnClickListener() {
        @Override
        public void onClick(View v) {
            EquipUnequip(w.WeaponID());
        }
    });
}

private void EquipUnequip(int WeaponId)
{
    if(Game.Weapons.get(WeaponId).CharacterID() == ChrSelected)
    {
        btnSelected.setImageResource(R.drawable.eqip_but_idle);
    }
    else
    {
        btnSelected.setImageResource(R.drawable.eqip_but_press);
    }
}

ll.addView(view);
i++;

Is there any reason why you don't use a listview with a custom adapter for that? — brummfondel
– brummfondel, Commented Jun 11, 2014 at 13:29
The opposide is correct if your data uses the same view: In a scrollview every view has to be created and hold in memory. Listviews recycle views. — brummfondel
– brummfondel, Commented Jun 11, 2014 at 13:44

fabian · Accepted Answer · 2014-06-12 15:52:24Z

1

The onClick method of OnClickListener has a parameter v. The value of v will be the View that was clicked, i.e. the ImageButton. All you have to do now is pass the View to EquipUnequip:

...
btnSelected.setOnClickListener(new OnClickListener() {
    @Override
    public void onClick(View v) {
        EquipUnequip(w.WeaponID(), (ImageButton)v);
    }
});
...

private void EquipUnequip(int WeaponId, ImageButton btnSelected) {
    if(Game.Weapons.get(WeaponId).CharacterID() == ChrSelected) {
        btnSelected.setImageResource(R.drawable.eqip_but_idle);
    } else {
        btnSelected.setImageResource(R.drawable.eqip_but_press);
    }
}

PS: This part seems a bit non-sensical to me:

View view = new View(this);
LayoutInflater inflater = (LayoutInflater) getApplicationContext().getSystemService(Context.LAYOUT_INFLATER_SERVICE);
view = inflater.inflate(R.layout.menuweapons_row, null);

Why do you create a new View just to do nothing with it and replace it with the result from the LayoutInflater?

Edit

If you really need the row of the View (and it never changes) here are 2 alternatives:

Save row in the OnClickListener

class MyOnClickListener implements OnClickListener {
    private final int rowIndex;
    MyOnClickListener(int rowIndex) {
        this.rowIndex = rowIndex;
    }

    @Override
    public void onClick(View v) {
        // do something with rowIndex
    }
}

and use it instead of your anonymus class or simply add a final variable outside your anonymus class:

// currentRowIndex calculated by your program
// i.e. incremented in every iteration
final int rowIndex = currentRowIndex;
btnSelected.setOnClickListener(new OnClickListener() {
    @Override
    public void onClick(View v) {
        // do something with rowIndex
    }
});

Add the info as tag to the button (currentRowIndex would be of type int):

btnSelected.setTag(currentRowIndex); // attach Integer data to the view
btnSelected.setOnClickListener(new OnClickListener() {
    @Override
    public void onClick(View v) {
        int rowIndex = (Integer)v.getTag();
        // do something with rowIndex
    }
});

edited Jun 12, 2014 at 15:52

answered Jun 11, 2014 at 13:30

fabian

82.9k12 gold badges99 silver badges124 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

SingleWave Games Over a year ago

So stupid of me should have spotted that it works thanks

SingleWave Games Over a year ago

I do actually have one follow up question, I forgot that within my dynamic code i also have an ImageView, that when clicked need to act in the same way the ImageButton does. How can i possibly detected the ImageButton row when seleteing the ImageView on the same row?

fabian Over a year ago

@LandLPartners: You can add a field to the Listener (non-anonymus class) or add a final variable in the loop (so that it can be accessed from the anonymus listener class), use setTag + getTag of the View, ...

SingleWave Games Over a year ago

I have tried this before, but cannot quite get it to work could you provide some sample code?

brummfondel · Accepted Answer · 2014-06-11 13:31:31Z

1

Give the View parameter of onClick() to EquipUnequip(), cast this to ImageButton and use it. Otherwise you get the last created button.

answered Jun 11, 2014 at 13:31

brummfondel

1,2101 gold badge8 silver badges11 bronze badges

Collectives™ on Stack Overflow

ScrollView - Adding dynamic rows from inflated xml layout

2 Answers 2

Edit

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Edit

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related