Sort block of Objects in Java ArrayList

Question

I have a block of data, and I want to sort them according to age and salary.

Object Employee has:

Name
Designation
Age
Salary

I want to sort then so that the max age will be on top. But if the age is same of two persons,then it will compare the salary between them, and then for whom Age and Salary is high, he will be on top of the ArrayList.

Here in the top list accordingly: Bob, Tim, Tom. then in the list: Alex, Sam, Craig and so on.

List<Employee> listEmployees = new ArrayList<Employee>(); 
listEmployees.add(new Employee("Tom", "Developer", 45, 80000));
listEmployees.add(new Employee("Sam", "Designer", 30, 75000));
listEmployees.add(new Employee("Bob", "Designer", 45, 134000));
listEmployees.add(new Employee("Peter", "Programmer", 25, 60000));
listEmployees.add(new Employee("Tim", "Designer", 45, 130000));
listEmployees.add(new Employee("Craig", "Programmer", 30, 52000));
listEmployees.add(new Employee("Anne", "Programmer", 25, 51000));
listEmployees.add(new Employee("Alex", "Designer", 30, 120000));

I have tried using

Collections.sort(Employees , new Comparator<listEmployees >() {
@Override
public int compare(EmployeeModelCls lhs, EmployeeModelCls rhs) {
return (rhs.getAge() - lhs.getAge());
}
});

also I have tried

Collections.sort(Employees , new Comparator<listEmployees >() {
@Override
public int compare(EmployeeModelCls lhs, EmployeeModelCls rhs) {
return ((rhs.getAge() - lhs.getAge()) - (rhs.getSalary() - lhs.getSalary()));
}
});

but unable to get correct data. Does anybody have any ideas?

Those sorting code blocks compile or am I missing something? — Timuçin
– Timuçin, Commented Jun 16, 2014 at 12:35

fajarkoe · Accepted Answer · 2014-06-16 12:46:30Z

Make the comparator as natural as possible, because it gives you clear idea how the employees are compared. For example,

Collections.sort(Employees , new Comparator<listEmployees >() {
  public int compare(EmployeeModelCls lhs, EmployeeModelCls rhs) {
    if (lhs.getAge() < rhs.getAge()) {
      return 1;
    } else if (lhs.getAge() > rhs.getAge()) {
      return -1;
    } else {
      if (lhs.getSalary() < rhs.getSalary()) {
        return 1;
      } else if (lhs.getSalary() > rhs.getSalary()) {
        return -1;
      } else {
        return 0;
      }
    }
  }
});

Once you do this, you can optimize the comparator. For example,

Collections.sort(Employees , new Comparator<listEmployees >() {
  public int compare(EmployeeModelCls lhs, EmployeeModelCls rhs) {
    return (rhs.getAge() == lhs.getAge()) ? (rhs.getSalary() - lhs.getSalary()) : (rhs.getAge() - lhs.getAge());
  }
});

As you can see, we compare the salaries only when the ages are the same. In your code, you compare the salaries even when the ages are not the same. This is the problem.

Brett Okken · Accepted Answer · 2014-06-16 12:36:24Z

1

Consider using guava's ordering utilities to create a compound comparator. In this specific case, it appears you need 2 comparators compounded together, first age then salary.

answered Jun 16, 2014 at 12:36

Brett Okken

6,3261 gold badge21 silver badges25 bronze badges

Comments

Unihedron · Accepted Answer · 2014-06-16 12:53:48Z

0

Maybe try this way

Collections.sort(listEmployees , new Comparator<listEmployees >() {
    @Override
    public int compare(EmployeeModelCls lhs, EmployeeModelCls rhs) {
        if (rhs.getAge() - lhs.getAge() == 0)
            return rhs.getSalary() - lhs.getSalary();

        return (rhs.getAge() - lhs.getAge());
    }
});

edited Jun 16, 2014 at 12:53

Unihedron

11.1k13 gold badges65 silver badges72 bronze badges

answered Jun 16, 2014 at 12:40

Heisenberg

3,2033 gold badges31 silver badges57 bronze badges

Collectives™ on Stack Overflow

Sort block of Objects in Java ArrayList

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related