User input validation with a foreach loop in form constructor

Question

I'm trying to use this custom method for user input validation in text boxes. But I feel something missing in this approach. Now use cant move to next text box if the validation failed. Is this a good thing or bad thing to do?

private void textBox_Validating(object sender, CancelEventArgs e)
{
    TextBox currenttb = (TextBox)sender;
    if (currenttb.Text == "")
    {
        MessageBox.Show(string.Format("Empty field {0 }", currenttb.Name.Substring(3)));
        e.Cancel = true ;
    }

    else
    {
        e.Cancel = false;
    }
}

Adding the handler to the textboxes with a foreach loop in the form constructor:

foreach(TextBox tb in this.Controls.OfType<TextBox>().Where(x => x.CausesValidation == true))
{
    tb.Validating += textBox_Validating;
}

Prisoner · Accepted Answer · 2014-06-19 09:20:39Z

1

How about using Error Provider, it will display exclamation if validation fail

answered Jun 19, 2014 at 9:20

Prisoner

1,8573 gold badges24 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Peter Liang · Accepted Answer · 2014-06-19 09:31:54Z

1

I thought it would be a bad user experience if you popup too much message box. May be you should consider use labels to display error message beside each text box. In your programm, I can't even close the window by clicking the close button if I left the text box empty.

answered Jun 19, 2014 at 9:31

Peter Liang

971 gold badge1 silver badge4 bronze badges

Collectives™ on Stack Overflow

User input validation with a foreach loop in form constructor

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related