MVC Exception: Ambiguous between the following action methods

Question

I am getting this error.

The current request for action 'Login' on controller type 'AccountController' is ambiguous between the following action methods:  
System.Web.Mvc.ActionResult Login(MVCApp.Models.Account) on type MVCApp.Controllers.AccountController  
System.Web.Mvc.ActionResult SignIn(MVCApp.Models.Account) on type MVCApp.Controllers.AccountController

Here is my Code

<input type="submit" name="Login" value="Login" />
<input type="submit" name="SignIn" value="SignIn" />

public class HttpParamActionAttribute : ActionNameSelectorAttribute
{
    public override bool IsValidName(ControllerContext controllerContext, string actionName, MethodInfo methodInfo)
    {
        if (actionName.Equals(methodInfo.Name, StringComparison.InvariantCultureIgnoreCase))
            return true;

        var request = controllerContext.RequestContext.HttpContext.Request;
        return request[methodInfo.Name] != null;
    }
}

public ActionResult Login()
{
    return View();
}

[HttpPost]
[HttpParamAction]
public ActionResult Login(Account account)
{
    Account createAccount = new Account();

    createAccount.Username = account.Username;
    createAccount.Email = account.Email;
    createAccount.Password = account.Password;

    return View("Login");
}

// GET: /Account/SignUp

public ActionResult SignIn()
{
    return View();
}

[HttpPost]
[HttpParamAction]
public ActionResult SignIn(Account account)
{
    Account createAccount = new Account();

    createAccount.Username = account.Username;
    createAccount.Email = account.Email;
    createAccount.Password = account.Password;

    return View("SignUp");
}

@3dd Here. is my route config public static void RegisterRoutes(RouteCollection routes) { routes.IgnoreRoute("{resource}.axd/{*pathInfo}"); routes.MapRoute( name: "Default", url: "{controller}/{action}/{id}", defaults: new { controller = "Account", action = "Login", id = UrlParameter.Optional } ); } — user3757426
– user3757426, Commented Jun 24, 2014 at 18:54

Grax32 · Accepted Answer · 2014-06-24 18:57:53Z

3

So you clicked the SignIn button which is routed to the Login action. The error is caused because HttpParamActionAttribute is returning true for IsValidName for both SignIn and Login actions.

Your HttpParamActionAttribute returns true for IsValidName against the Login action because the Login action matches by name.

Now your other HttpParamActionAttribute on SignIn also returns true because request["SignIn"] is not equal to null.

Change your view to look for an action that is not "LogIn" and also not "SignIn". That way only the action that matches the button name will return true for IsValidName.

answered Jun 24, 2014 at 18:57

Grax32

4,0791 gold badge20 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

MVC Exception: Ambiguous between the following action methods

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related