Mongoose null checking before saving on nested schema array

Question

I have an Schema model like this:

var propertySchema = new Schema({
  name: {type: String, required: true},
  surname: String
});

var objSchema = new Schema({
  properties: [prepertySchema]
});

var accountSchema = new Schema({
  objects: [objSchema]
});

mongoose.model('account', accountSchema);

Then i have the operations:

account.objects.push(null);
account.save(function(error, account) {
   //Error checking and response
})

In that case, i'm getting a ValidationError because of the null value. This is expected. But, in the next operations:

var obj = {properties: null}
account.objects.push(obj);
account.save(function(error, account) {
   //Error checking and response
})

Here the value is stored on database, and then i have an unexpected null value where it had been an array. Doing that with objects like this,

var obj = {
   properties: [{name:'randname'}, null]
}

Also saves null values in the database that are prohibited to the data model.

I've read about validators, and middleware for checking things. Is there anyway to do this directly on the schema, or i have to parse the received object before i save it in the database? What is the best approach for this?

Neil Lunn · Accepted Answer · 2014-06-26 09:22:24Z

3

Well you could just use the model definitions for this. Even though you are embedding you can still do this but of course you do not want to actually save the objects to their own collection. Just feed them into the item as embedded:

  var async = require("async"),
      mongoose = require("mongoose"),
      Schema = mongoose.Schema;

  mongoose.connect('mongodb://localhost/prop');

  var propertySchema = new Schema({
      name: { type: String, required: true },
      surname: String
  });

  var objSchema = new Schema({
      properties: [propertySchema],
  });

  var accountSchema = new Schema({
      objects: [objSchema]
  });

  var Account = mongoose.model( 'account', accountSchema );
  var ObjMod = mongoose.model( 'ObjMod', objSchema, null, false );
  var PropMod = mongoose.model( 'PropMod', propertySchema, null, false );

  var account = new Account();

  var prop = new PropMod({ "name": null  });
  var obj = new ObjMod({ properties: prop });
  account.objects.push( obj );

  account.save(function(err,account) {
      if (err) throw err;

      console.log( JSON.stringify( account, undefined, 4 ) );

  });

So what happens there is the validation will work for each stage, in this case it will fail on the name of the property schema item not being a string or even if not included.

answered Jun 26, 2014 at 9:22

Neil Lunn

151k36 gold badges356 silver badges327 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Bertofer Over a year ago

Thanks for the quick response! I've tried it, but the case where var obj = new ObjMod({ properties: null }); still inserts a null into the database. Any way to solve that?

Neil Lunn Over a year ago

@Sugarl3ss you can add other validation in that case. Just a problem where the null type does not fall into the the basic validation. But the point is if you structure like this then most of your problems should go away without writing loads of validation code.

Bertofer Over a year ago

Ok, then i will add some validators for that cases.

Collectives™ on Stack Overflow

Mongoose null checking before saving on nested schema array

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related