jslint error..Don't make functions within a loop

Question

In the below piece of code I am getting the JSLint error (Don't make functions within a loop). can you help me to modify the code to satisfy the JSLint.

setEllipsis : function () {
    $('.co_documentReportTable > thead > tr > th').each(function() {
        $(this).find('.co_dcrTable_Header').each(function() {
            var $el = $(this);
            if($el.css("overflow") === "hidden") {
                var text = $el.html();
                while ($el.height() > 64) {
                    $el.text(function (index, text) {
                        return text.replace(/\W*\s(\S)*$/, '...');
                    });
                    //
                    var txt = 'Fair consideration/no fraudulent conveyance';
                    if(text.indexOf(txt) !== -1 ) {
                        $el.text(txt + '...');
                    }
                }
            }
        });
    });
}

I tried creating another function and calling it then in that case while loop is getting executed forever.

this is for multiline and above code works but am getting jslint error how to resolve the jslint error ? — user3496151
– user3496151, Commented Jun 26, 2014 at 15:25

Woody · Accepted Answer · 2014-06-26 15:26:05Z

Looks in general like you want to use the text-overflow: ellipses CSS property instead here.

Otherwise - pull the anonymous function up and give it a name, so you might end up with :

setEllipsis : function () {
    var addEllipses = function(index, text) {
        return text.replace(/\W*\s(\S)*$/, '...');
    };

    $('.co_documentReportTable > thead > tr > th').each(function() {
        $(this).find('.co_dcrTable_Header').each(function() {
            var $el = $(this);
            if($el.css("overflow") === "hidden")
            {
                var text = $el.html();
                while ($el.height() > 64) {
                    $el.text(addEllipses);
                    var txt = 'Fair consideration/no fraudulent conveyance';
                    if(text.indexOf(txt) !== -1 ){
                        $el.text(txt + '...');
                    }
                }
            }           
        });
    });
}

Collectives™ on Stack Overflow

jslint error..Don't make functions within a loop

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related