how to insert data from database in combox

Question

I'm trying to insert data from my database in a combo box specifically showing all my tables in the combobox here's my connection

private void Form1_Load(object sender, EventArgs e)
{
     string connetionString = null;
     SqlConnection cnn;
     connetionString = "Data Source=ITWORKSDEV01;Initial Catalog=ITWorksDEV";
     cnn = new SqlConnection(connetionString);

     for (int i = 0; i < 5; i++)
     {
         comboBox1.Items.Add(i.ToString());
     }
 }

After update in the question. Still code is not enough. It is recommended to search about the topic — Hassan Nisar
– Hassan Nisar, Commented Jun 27, 2014 at 5:57
YOu're only creating a connection - you're not actually executing any SQL query against the database! — marc_s
– marc_s, Commented Jun 27, 2014 at 6:06

Community · Accepted Answer · 2017-05-23 12:03:49Z

1

First of all, which database-type are you using ?

You can look-up the correct connection-code for each database here: http://www.connectionstrings.com/

Second, don't forget to open the connection:

private void Form1_Load(object sender, EventArgs e)
{
     string connetionString = null;
     connetionString = "Data Source=ITWORKSDEV01;Initial Catalog=ITWorksDEV";
     using (SqlConnection cnn = new SqlConnection(connetionString))
     {
         cnn.Open();

After you opened the connection, create a DataReader and a SQL-Statement:

SqlDataReader and SqlCommand

}
}

Closing/Disposing isn't needed here, using makes that job for you.

But stackoverflow is not a place where we write you the code, you have to write it by yourself and if you get errors we can help you.

Good luck!

edited May 23, 2017 at 12:03

CommunityBot

11 silver badge

answered Jun 27, 2014 at 5:59

DatRid

1,1792 gold badges21 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Sergey Berezovskiy Over a year ago

Note: closing connections is also very important

DatRid Over a year ago

@SergeyBerezovskiy Yes you are right. Closing/Disposing(which includes closing) is important, will add it to the answer.

Sergey Berezovskiy Over a year ago

Second note :) It's better to use using statement to close connection even if exception happens

DatRid Over a year ago

@SergeyBerezovskiy True the second :P Actually I normally use using, I think I just wanted to fix the OP's-code and didn't improve it. My bad :)

Collectives™ on Stack Overflow

how to insert data from database in combox

1 Answer 1

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related