Database Tables not defined in DJANGO models

Question

Is it fine not to define table stucture in models.py...I mean we are using

cursor.execute('some query')

so its okay not to make something like this :

def tblNew(models.Model) col1 = models.CharField(max_length=2)

Thanks for guidance, Im a newbie in django.

No it's not ok. Database's logic should be located in models - MVC pattern — pancakes
– pancakes, Commented Jul 1, 2014 at 8:37
but my co-team refused to create table structure in models.py and instead create database tables directly at postgre...i said that we have to follow what's in django documentation..can you tell me what would be our problems if we didnt define table in models.py? — user3204806
– user3204806, Commented Jul 1, 2014 at 8:40
If you are not going to use built-in Django ORM features - it's kind of ok. Otherwise you have to declare your db structure in models.py. Also, you'd better have really solid argument for not using built-in ORM features (e.g. "we're going to use SQLAlchemy" or "ORMs sucks" :)) — J0HN
– J0HN, Commented Jul 1, 2014 at 8:40
Looks like you are confusing "code-first" approach with using ORM at all. If you have existing db, you can still use Django ORM by going "db first". there's an article in django docs on how to integrate django with legacy (read: pre-existing) database. So just let them have their database structure declared where they want it to be, and adapt :) — J0HN
– J0HN, Commented Jul 1, 2014 at 8:42

Odif Yltsaeb · Accepted Answer · 2014-07-01 08:50:15Z

1

You CAN create database tables directly in postgresql But you'd have to create models.py files later because otherwise you will be missing out on several things. If you have pre-existing database, then you have django-admin.py command to pick them up for you (https://docs.djangoproject.com/en/dev/ref/django-admin/#inspectdb)

ORM. It makes alot of things easyer. Writing sql in views? Why would that be good? Because that is what you get if you do not use ORM at all. And while i do have sql in some of my views, it only exists there because django lacks some features like language collation specific sorting. But otherwise writing sql in views hampers readability.
You can't use database migrations. South (http://south.aeracode.org/) is one awesome project that most big django projects use. In fact i think it was most used django project in some apps poll. Django 1.7 will provide the migrations too, but you will need to declare models im models.py for that. What you loose if you do not use database migrations - SANITY. I do not exaggerate here. Keeping track of database changes in development and prelive/live servers is nightmare otherwise.
Also is not using django ORM in some places (not declaring models) kind of strange, while you will definately use django models and ORM elsewhere - or will you stop using django authentication, sessions and site logic also? All those use django ORM...

answered Jul 1, 2014 at 8:50

Odif Yltsaeb

5,68614 gold badges55 silver badges82 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

J0HN Over a year ago

Just a little suggestion - you should never write sql in views. Move it to models or to "application logic" layer. By accessing database in views you essentially tie your views to database, which greatly increases coupling and could potentially lead to problems in the future (e.g. migrating to another DB engine, introducing some common db-related functionality, etc.). In my opinion, custom SQL is a perfect use case for custom model manager.

Odif Yltsaeb Over a year ago

aye. I just kept dreaming that code.djangoproject.com/ticket/21181 will happen soon and never bothered to rework temporary solution into more permanent one :/

Collectives™ on Stack Overflow

Database Tables not defined in DJANGO models

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related