$_FILES empty when uploading Magento package

Question

I am trying to install a Magento package, but I get No file was uploaded

Its coming from this code because $_FILES is an empty array in /downloader/Maged/Controller.php

/**
 * Install uploaded package
 */
public function connectInstallPackageUploadAction()
{
    if (!$_FILES) {
        echo "No file was uploaded";
        return;
    }

    if(empty($_FILES['file'])) {
        echo "No file was uploaded";
        return;
    }

    $info =& $_FILES['file'];

    if(0 !== intval($info['error'])) {
        echo "File upload problem";
        return;
    }

    $target = $this->_mageDir . DS . "var/" . uniqid() . $info['name'];
    $res = move_uploaded_file($info['tmp_name'], $target);
    if(false === $res) {
        echo "Error moving uploaded file";
        return;
    }

    $this->model('connect', true)->installUploadedPackage($target);
    @unlink($target);
}

It might be worth noting that product uploads work fine.

The only log output I get is

2014-07-03T18:44:15+00:00 ERR (3): Warning: array_key_exists() expects parameter 2 to be array, null given in /var/www/vhosts/example.com/httpdocs/app/code/core/Mage/Captcha/Model/Observer.php on line 166

exception.log was empty

Make sure you are using enctype="multipart/form-data" on your form. — Raggamuffin
– Raggamuffin, Commented Jul 2, 2014 at 16:55
The form is within the Magento Connect page, so I would hope it does! A quick look shows it does. — Jake N
– Jake N, Commented Jul 2, 2014 at 17:00

user2361810 · Accepted Answer · 2014-07-03 05:30:57Z

1

Make sure that your var folder in magento installation is fully writable. 777 permission. All folders and files.

answered Jul 3, 2014 at 5:30

user2361810

191 bronze badge

Sign up to request clarification or add additional context in comments.

4 Comments

Jake N Over a year ago

Did that too. It would be a permissions error if that were the case? Rather than _FILES being empty?

user2361810 Over a year ago

Yes, when uploading is done in magento they are initially uploaded to one of the var folders and then used. If files have not been uploaded hence $_FILES empty. Check your log and system exception files it may be other issues as well.

Jake N Over a year ago

Thats not it, var is completed 777'd and its the same

user2361810 Over a year ago

Can you add logs and exception files. We can get detailed info from there.

Kevin Sandow · Accepted Answer · 2014-07-08 09:13:37Z

1

You can try uploading a small dummy file first to check if the error stays the same.

There is a file upload limit which might be reached.

File upload often fails due to upload_max_filesize or post_max_size being too small as mentioned in Common Pitfalls section of the PHP documentation.

answered Jul 8, 2014 at 9:13

Kevin Sandow

4,0331 gold badge22 silver badges33 bronze badges

1 Comment

Jake N Over a year ago

A tiny file (7KB) fails also. Image files work fine from within Magento's usual admin area.

MTM · Accepted Answer · 2014-07-10 08:11:30Z

1

Use firebug in firefox to check if your form does has enctype="multipart/form-data".

edited Jul 10, 2014 at 8:11

answered Jul 8, 2014 at 14:01

MTM

91910 silver badges22 bronze badges

4 Comments

Jake N Over a year ago

It does. See comments on the original question.

MTM Over a year ago

Is the action of your form directs to connectInstallPackageUpload?

Jake N Over a year ago

Yes, here is the full form element

<form action="/downloader/index.php?A=connectInstallPackageUpload" method="post" target="connect_iframe" onsubmit="onSubmit(this)" enctype="multipart/form-data">

MTM Over a year ago

try to print values in indexAction(), use condition like if(isset($_FILES)){print_r($_FILES);exit;} at the start of the indexAction()

ArtisticPhoenix · Accepted Answer · 2014-07-13 20:35:50Z

1

Check the user group it was created with,

To explain, recently I had some file saving issues. Turned out I had created the folder using the Root user for the server, and the CPanel user ( the one php was running under ) didn't have permission to write in folders owned by the Root account, even when setting the permissions to 777.

Just a thought.

answered Jul 13, 2014 at 20:35

ArtisticPhoenix

21.7k2 gold badges27 silver badges38 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 11:43:42Z

1

First check if your installation is configured properly see@http://php.net/manual/en/features.file-upload.common-pitfalls.php

Also, if you upload with PUT/xhr the file is on the input stream

$in = fopen('php://input','r');

see@http://php.net/manual/en/features.file-upload.put-method.php and https://stackoverflow.com/a/11771857/2645347,

this would explain the empty $FILES array, in case all else is ok and the upload works via xhr/PUT.

edited May 23, 2017 at 11:43

CommunityBot

11 silver badge

answered Jul 14, 2014 at 11:45

birdspider

3,0941 gold badge18 silver badges25 bronze badges

Comments

sensorario · Accepted Answer · 2014-07-14 12:08:13Z

1

$_FILES is an associative array of items uploaded to the current script via the HTTP POST method. All uploaded files are stored in $HTTP_POST_FILES contains the same initial information, but is not a superglobal. So, ... be sure that method is POST

Always check that your form contains correct enctype:

<form ... enctype="multipart/form-data"> ... </form>

Sometimes happens that when someone upload multiples file, $_FILES return empty. This could happen when I select files that exceed some size. The problem can be in the POST_MAX_SIZE configuration.

answered Jul 14, 2014 at 12:08

sensorario

21.9k31 gold badges105 silver badges177 bronze badges

1 Comment

Jake N Over a year ago

This isn't it, please read other comments and answers before posting

peterpeterson · Accepted Answer · 2014-07-14 15:47:44Z

1

On

app/code/core/mage/captcha/model/observer.php

change

public function checkUserLoginBackend($observer)
{
$formId = 'backend_login';
        $captchaModel = Mage::helper('captcha')->getCaptcha($formId);
        $loginParams = Mage::app()->getRequest()->getPost('login');
        $login = array_key_exists('username', $loginParams) ? $loginParams['username'] : null;
        if ($captchaModel->isRequired($login)) {
            if (!$captchaModel->isCorrect($this->_getCaptchaString(Mage::app()->getRequest(), $formId))) {
                $captchaModel->logAttempt($login);
                Mage::throwException(Mage::helper('captcha')->__('Incorrect CAPTCHA.'));
            }
        }
        $captchaModel->logAttempt($login);
        return $this;
    }

to

public function checkUserLoginBackend($observer)
{
    $formId = 'backend_login';
    $captchaModel = Mage::helper('captcha')->getCaptcha($formId);

    $login = Mage::app()->getRequest()->getPost('username');
    if ($captchaModel->isRequired($login)) {
        if (!$captchaModel->isCorrect($this->_getCaptchaString(Mage::app()->getRequest(), $formId))) {
            $captchaModel->logAttempt($login);
            Mage::throwException(Mage::helper('captcha')->__('Incorrect CAPTCHA.'));
        }


    }
    $captchaModel->logAttempt($login);
    return $this;
}

Your issue is: "Captcha Observer throws an error if login in RSS feed" issue #208

or if you wish you could only replace the variable $login to be like this:

$login = array_key_exists('username', array($loginParams)) ? $loginParams['username'] : null;

answered Jul 14, 2014 at 15:47

peterpeterson

1,3262 gold badges15 silver badges41 bronze badges

11 Comments

Jake N Over a year ago

Thats a good shout, but its not worked. If I put a die statement in that function it does die. So it is running your code, its just not fixed it.

peterpeterson Over a year ago

and what happen if you put print_r($_FILES); die(); ?

Jake N Over a year ago

I get a blank array. I have now upgraded to Magento 1.9 and get the same issue.

peterpeterson Over a year ago

That's weird, what kind of error_reporting do you have activated? if not already can you change to E_ALL and run your code again, so if there is a notice of an empty variable, we may have more chances to debug.

Jake N Over a year ago

Where is best to add this within Magento. I know how to do it, but just unsure when it comes to Magento?

|

Community · Accepted Answer · 2017-05-23 10:26:56Z

-1

You may try out below points. Use Magento Varien File Uploaded Classes to Upload the files.

Magento File Uploader

1) Check enctype="multipart/form-data" in your form.

2) Use Magento Form Key in your form.

3) Use Varien file uploader to upload your files using below links answers.

edited May 23, 2017 at 10:26

CommunityBot

11 silver badge

answered Jul 12, 2014 at 10:55

Maniprakash Chinnasamy

2,77632 silver badges56 bronze badges

Collectives™ on Stack Overflow

$_FILES empty when uploading Magento package

8 Answers 8

4 Comments

1 Comment

4 Comments

Comments

Comments

1 Comment

11 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

8 Answers 8

4 Comments

1 Comment

4 Comments

Comments

Comments

1 Comment

11 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related