SerializationException: "Type\...\ in assembly\...\ is not marked as serializable" appears when I try to serialize ObservableCollection

Question

In duplex WCF service that works as parralel downloadmanager I have Downloader class that presents each download status and an ObservableCollection that contains Downloader instanses. When I try to serialize ObservableCollection via BinaryFormatter then I get SerializationException with message: "Type\System.Net.ConnectStream\ in assembly\System.Version 4.0.0.0, Culture=neutral, PublicKey Token=b77a5c561934e089\ is not marked as serializable". Below is condenced version of Downloader class:

[Serializable()]
public class Downloader
{
     /// <summary>
     /// "Download status changed" event.
     /// </summary>
     [field: NonSerialized()]
     public event EventHandler<InServiceHandledDownloadStatusChangedEventArgs>    InServiceHandledDownloadStatusChanged;

     /// <summary>
     /// URL of downloaded resource.
     /// </summary>
     private String _targetUrl;  

     /// <summary>
     /// Path to save downloaded data on local drive.
     /// </summary>
     private String _pathToSave;

     /// <summary>
     /// The number of bytes downloaded from internet resource.
     /// </summary>
     private Int64 _downloadedBytesQuantity = 0;

     /// <summary>
     /// Current status of downloading ("Await", "Running", "Completed").
     /// </summary>
     private String _status = "Added";

     /// <summary>
     /// Task that performs download.
     /// </summary>
     [NonSerialized()]
     public Task TaskPerformingDownload;

     /// <summary>
     /// The source of cancellation token for cancelling of TaskPerformingDownload.
     /// </summary>
     [NonSerialized()]
     public CancellationTokenSource CancelDownloadTokenSource;

     /// <summary>
     ///  Gets or sets stream to read downloaded data from internet.
     /// </summary>
     public Stream ReadСontentStream { get; set; }

     /// <summary>
     /// Gets or sets stream to write downloaded data to local drive.
     /// </summary>
     public Stream SaveСontentStream { get; set; }

     /// <summary>
     /// This method executes in TaskPerformingDownload and performs downloading.
     /// of a resource from internet.
     /// </summary>
     /// <param name="p_CancellationToken">Cancellation Token</param>
     public void PerformDownload(Object p_CancellationToken)
     {
         try
         {
             // Get cancellation token.
             CancellationToken cancellationToken = (CancellationToken)p_CancellationToken;
             // Check was the task canceled?
             cancellationToken.ThrowIfCancellationRequested();
             . . . . . . . . 
             HttpWebRequest webResourceRequest = (HttpWebRequest)WebRequest.Create(TargetUrl);
             HttpWebResponse webResourceResponse = (HttpWebResponse)webResourceRequest.GetResponse();
             this.ReadСontentStream = webResourceResponse.GetResponseStream();
             this.SaveСontentStream = new FileStream(this.PathToSave, FileMode.Create, FileAccess.Write, FileShare.None);
             int bytesReceivedInChank = 0;
             byte[] downloadBuffer = new byte[2048];

             // The downloading loop.
             while ((bytesReceivedInChank = this.ReadСontentStream.Read(downloadBuffer, 0, downloadBuffer.Length)) > 0)
             {
                  if (cancellationToken.IsCancellationRequested)
                    cancellationToken.ThrowIfCancellationRequested();
                  this.SaveСontentStream.Write(downloadBuffer, 0, bytesReceivedInChank);
                  . . . . . . . .
             }
        }
        catch(Exception){. . . .}
        finally
        {
            if (this.ReadСontentStream != null)
            {
                this.ReadСontentStream.Close();
                this.ReadСontentStream.Dispose();
            }
            if (this.SaveСontentStream != null)
            {
                this.SaveСontentStream.Close();
                this.SaveСontentStream.Dispose();
            }
        }
     }
}

TaskPerformingDownload member is a TPL task performing one download. It is started from StartDownload() contract method which WCF service calls when client asks to do it. PerformDownload method is executed in this task. WCF service create as many Downloader instances as many downloads must be performed. One Downloader instance per each download. A SerializationException exception with message: "Type\System.Net.ConnectStream\ in assembly\System.Version 4.0.0.0, Culture=neutral, PublicKey Token=b77a5c561934e089\ is not marked as serializable" occurs only when I try to serialize ObservableCollection with completed downloads. When download is completed its task (TaskPerformingDownload member) has completed its work too and has no more executed. I try to dispose task in completed download but it doesn't help and SerializationException exception remains. But if there are only new downloads in the ObservableCollection so the downloads that havn't been run yet (so that the TaskPerformingDownload member of this download hasn't run yet) that in that case the ObservableCollection is serialized nice without any exceptions or errors. Can you give me any tip why this situation has place? It is very important for me.

Marc Gravell · Accepted Answer · 2014-07-04 11:25:07Z

4

You are trying to serialize a Stream. That is a recipe for disaster: streams are not buckets of data - they are pipes; they are very rarely serializable in any meaningful way, if at all. My advice simply: don't do that. In fact, don't try serializing Downloader at all; you should serialize data, not the implementation state. Create a separate model that is simply intended for serialization, and which contains the data you want to store in the simplest most obvious way. If you want to serialize a binary request / response: byte[]. And so on.

Also: I strongly advise against using BinaryFormatter in virtually all scenarios, for multiple reasons.

answered Jul 4, 2014 at 11:25

Marc Gravell

1.1m273 gold badges2.6k silver badges3k bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user3769902 Over a year ago

I did Streams as fields in class and put on each of them [NonSerialized()] attribute and after it all is very well. There is no SerializationException! Ti is nice!

Marc Gravell Over a year ago

@user3769902 but also : no data

Eugene Podskal · Accepted Answer · 2014-07-04 11:31:33Z

0

BinaryFormatter.Serialize method documentation directly says:

SerializationException is thrown when:
An error has occurred during serialization, such as if an object in the graph parameter is not marked as serializable.

There is nothing you can do short of not using the problem objects.

I am not sure even why would you need the System.Net.ConnectStream to be serialized - it is too context (machine)specific.

Also you may try to implement the ISerializableInterface in your class.

edited Jul 4, 2014 at 11:31

answered Jul 4, 2014 at 11:23

Eugene Podskal

10.4k5 gold badges34 silver badges56 bronze badges

1 Comment

user3769902 Over a year ago

I exclude members of type Stream from serialization and now is OK. Serialization works good now!

ZZZ · Accepted Answer · 2014-07-04 12:31:51Z

Stream as its name indicated, is stream -- which is just a pointer of starting point a data stream lasting on and on. If you have done C/C++ programming, you should know "That is a recipe for disaster". Stream is NOT data, but a pipe or socket for reading and writing arbitrary length of data.

If you want to serialize the data obtained from the stream, then get the data first for the data object, particularly POCO - Plain Old CLR Object.

For example,

class DownloaderData
{
...
public byte[] ContentData {get;set;}
...
}

and in class Downloader, you should use stream to read all the data into the byte array buffer.

Separating the data and the handler function into 2 classes will make your write less codes in less complex structure with less headache in long run.

Collectives™ on Stack Overflow

SerializationException: "Type\...\ in assembly\...\ is not marked as serializable" appears when I try to serialize ObservableCollection

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related