Can not inject factory into angularjs controller

Question

Why is the WizardPageSchoolclassCodesFactory factory not injected? Its always null!

The error in my chrome console is this:

Error: [$injector:unpr] Unknown provider: $scopeProvider <- $scope <- WizardPageSchoolclassCodesFactory



    angular.module('myModule').controller('WizardMainController', function ($scope, WizardPageSchoolclassCodesFactory) {

    // do stuff with data

    });

'use strict';
angular.module('myModule').factory('WizardPageSchoolclassCodesFactory', function($scope) {
        this.getData = function()
        {
            return "hello";
        }
});

Remove injection of $scope from factory definition and create an API in the factory. — dmahapatro
– dmahapatro, Commented Jul 18, 2014 at 21:47
Why can I not inject the scope into the factory? I removed the $scope but nothing changed! — Elisabeth
– Elisabeth, Commented Jul 18, 2014 at 21:48
Sorry remove $scope helped, I just got another error which was misleading! — Elisabeth
– Elisabeth, Commented Jul 18, 2014 at 21:52
Your factory is declared like a service. A factory should be a function that returns an object. — Anthony Chu
– Anthony Chu, Commented Jul 18, 2014 at 21:53

akn · Accepted Answer · 2014-07-18 21:54:24Z

0

If you want to pass scope into your factory you can do it in this way:

app.factory('WizardPageSchoolclassCodesFactory', function() {
    return function(scope){
        this.getData = function()
        {
            scope.test = "test";
            return "hello";
        }
    }
});

In controller you have to create new instance of your factory and pass scope in constructor:

var factory = new WizardPageSchoolclassCodesFactory($scope);

Then you can use declared factory methods:

factory.getData();

http://jsfiddle.net/aartek/THE4P/

answered Jul 18, 2014 at 21:54

akn

3,7221 gold badge29 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Elisabeth Over a year ago

Surely I do NOT want to bring the $scope outside a controller. I just wanted to know the technical reason why I get an 'exception' doing this...

dmahapatro Over a year ago

This way you are tightly coupling the factory with the controller. Factory should be abstracted from the controller logic. You can send the variable test to factory instead of sending the scope altogether. Makes sense?

akn Over a year ago

@dmahapatro you're right, but sometimes passing scope has advantages. For example recently I had to create widgets dashboard - each widget has it own scope and widgets should communicate with each other by sending/receiving events. Instead of repeating same code in each controller, I inject factory with passed scope, and this factory creates listeners for me. It looks like this: pastebin.com/xMGZha2v. Instead of writing scope.$on... I can simply register listeners to scope by using factory methods.

PSL Over a year ago

Passing controller scope in a factory is a bad practice... It is a clear violation of encapsulation IMHO.

Collectives™ on Stack Overflow

Can not inject factory into angularjs controller

1 Answer 1

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related