How should I insert data from a program in java to a database in mysql? [closed]

Question

Closed. This question does not meet Stack Overflow guidelines. It is not currently accepting answers.

This question does not appear to be about programming within the scope defined in the help center.

Closed 11 years ago.

this is the code what I am using to insert the data. Is this the best way?

       try 
      {
           st =  conect.createStatement();
           sql_v = "insert into VENDEDORES(ID,name,firstlast_name,secondlast_name,phone,celphone) \n"
                  + " values("+ID+",'name','fln','sln','ph','clp')";

          st.executeUpdate(sql_v);
      } 
      catch (Exception ex) {
            JOptionPane.showMessageDialog(null,"","ERROR",JOptionPane.ERROR_MESSAGE);
      }

This question appears to be off-topic because it is about improving working code. It is more suited for codereview.stackexchange.com — Gerald Schneider
– Gerald Schneider, Commented Jul 22, 2014 at 19:39

Community · Accepted Answer · 2017-05-23 11:50:19Z

5

Is this the best way?

No its not the best way.

I suggest to use PreparedStatement

Advantage of using PreparedStatement over Statement

A SQL statement is precompiled and stored in a PreparedStatement object.
This object can then be used to efficiently execute this statement multiple times.
Reduces execution time.
Automatic prevention of SQL injection attacks by builtin escaping of quotes and other special characters

Read more PreparedStatements and performance

Here is the sample code provided by mkyong

edited May 23, 2017 at 11:50

CommunityBot

11 silver badge

answered Jul 22, 2014 at 19:37

Braj

46.9k5 gold badges63 silver badges77 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Cruncher Over a year ago

protection against SQL injection should really be #1

Braj Over a year ago

@Cruncher that's I used bullet points instead of giving it numbering.

Cruncher Over a year ago

I get it. I was just emphasising. BTW, I'm pretty sure that if you one-off a prepared statement, then it's actually slower than a statement. I could be wrong on that though.

Collectives™ on Stack Overflow

How should I insert data from a program in java to a database in mysql? [closed]

1 Answer 1

3 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Linked

Related