JavaScript timer is not working

Question

I have created a file named ExtremeNotifications.js and added to the _Layout.cshtml master layout.

The ExtremeNotifications.js includes the following JavaScript code:

var extremeNotifications = extremeNotifications || {};

extremeNotifications = (function () {

    var baseURL = document.baseURI;
    var url = baseURL + 'api/usernotifications';
    var isNotificationServiceStarted = false;
    var timer;

    function getPendingNotifications() {
        $.ajax({ url: url, success: dataRetrieved, type: 'GET', dataType: 'json' });
    }

    function dataRetrieved(data) {
        alert(data);
    }

    function startNotifications() {
        if (!isNotificationServiceStarted) {
            timer = setInterval(getPendingNotifications, 3000);
            isNotificationServiceStarted = true;
        }
    }

    function stopNotifications() {
        clearInterval(timer);
        isNotificationServiceStarted = false;
    }

    return {
        start: startNotifications(),
        getPendingNotifications: getPendingNotifications(),
        isNotificationServiceStarted: isNotificationServiceStarted,
        stop: stopNotifications()
    }
})();

Then in my Home Index.cshtml I start the notifications with the following code and only if User.Identity.IsAuthenticated:

<script>
   extremeNotifications.start();
</script>

So now when my page starts and I'm authenticated user I get an alert box in the first time but I never see another alert after 3 seconds.

Any comments?

Pointy · Accepted Answer · 2014-07-26 14:25:01Z

2

You're close, but you're creating that returned object incorrectly:

return {
    start: startNotifications,
    getPendingNotifications: getPendingNotifications,
    isNotificationServiceStarted: isNotificationServiceStarted,
    stop: stopNotifications
};

By including the () after the function names, your code was calling the functions and returning their return values instead of returning references to the functions themselves.

answered Jul 26, 2014 at 14:25

Pointy

415k62 gold badges600 silver badges632 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

xplat Over a year ago

oops! Forgot that, had so long to write JavaScript! It Works now, thanks.

Collectives™ on Stack Overflow

JavaScript timer is not working

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related