Objective-C NSMutableArray alloc init on already declared Object

Question

I have been tasked with "cleaning up" someone else's Objective-C code. I will admit, it is certainly not my favorite language.

One method i found in this user's code that seems redundant to me is this:

if (favoriteItemsArray || [favoriteItemsArray count] > 0) {
    [favoriteItemsArray removeAllObjects];
    favoriteItemsArray = nil;
}

if (favoriteOrderArray || [favoriteOrderArray count] > 0) {
    [favoriteOrderArray removeAllObjects];
    favoriteOrderArray = nil;
}

favoriteItemsArray = [[NSMutableArray alloc] init];
favoriteOrderArray = [[NSMutableArray alloc] init];

I wanted to double check with you all and see if i am just too use to JAVA, but couldn't this code be condensed to just the last two lines and just merely say:

favoriteItemsArray = [[NSMutableArray alloc] init];
favoriteOrderArray = [[NSMutableArray alloc] init];

If not can someone explain?

Again this is not my code..

I am trying to think of some vague situation of retention that requires removing the objects before reinitializing, but I can't come up with one. I'd say go ahead with your approach. — Logan
– Logan, Commented Jul 28, 2014 at 19:27
Those two if statements are bad. The || part is pointless. — rmaddy
– rmaddy, Commented Jul 28, 2014 at 19:28
Are the last two lines inside or outside the 1st if statement? You don't show the closing curly brace. — rmaddy
– rmaddy, Commented Jul 28, 2014 at 19:29
the || is pointless as well, I agree.. the two init/alloc statements are out side both if conditions — erik
– erik, Commented Jul 28, 2014 at 19:30

Philippe Leybaert · Accepted Answer · 2014-07-28 19:27:38Z

5

You are correct. You can remove the first part of the code (if ARC is used for reference counting). When the arrays are reassigned, the previous array will be freed because the retain count will reach zero and all objects in the array will also be released.

answered Jul 28, 2014 at 19:27

Philippe Leybaert

172k33 gold badges213 silver badges224 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

erik Over a year ago

i will accept this answer in a few minutes (StackOverFlow won't let me yet.. that was an easy reputation booster!

Collectives™ on Stack Overflow

Objective-C NSMutableArray alloc init on already declared Object

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related