java.util.concurrent.ThreadPoolExecutor strange logic

Question

Look ath this method of ThreadPoolExcecutor:

public void execute(Runnable command) {
    ...
        if (runState == RUNNING && workQueue.offer(command)) {
            if (runState != RUNNING || poolSize == 0)
                ensureQueuedTaskHandled(command);
        }
    ...
}

It check that runState is RUNNING and then the oposite. As I'm trying to do some tuning on a SEDA like model I wanted to understand the internals of the thread pool.
Do you think this code is correct?

Adamski · Accepted Answer · 2010-03-23 15:15:37Z

2

The executor's runState can potentially change between the initial check and the subsequent check after the command is added to the queue. One reason for this is if the executor's shutdown() method is called.

The second check is performed so that if the executor has been shut-down then any queued tasks are handled appropriately rather than being stranded on the queue.

answered Mar 23, 2010 at 15:15

Adamski

54.8k15 gold badges121 silver badges154 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Alexander Pogrebnyak · Accepted Answer · 2010-03-23 15:12:07Z

2

runState is volatile, so yes its state can change after initial check and a call to workQueue.offer

answered Mar 23, 2010 at 15:12

Alexander Pogrebnyak

45.8k10 gold badges111 silver badges123 bronze badges

Collectives™ on Stack Overflow

java.util.concurrent.ThreadPoolExecutor strange logic

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related