integer expression expected error.

Question

I don't know why I am getting this error --> : integer expression expected: [: 82 value 82 comes from CURRENT. I am trying to grab the disk space usage and assign to variable called CURRENT and then email out. I don't know where I am going wrong? Any help is appreciated.

#!/bin/bash
[email protected]
THRESOLD=80
CURRENT=$(df -H | grep '/dev/mapper/cvs-cvs' | awk '{ print $5}' | cut -d'%' -f1)
if  [ $CURRENT -ge $THRESOLD ]; then 
    echo "My CVS disk space usage is $CURRENT %" | mailx -s "Disk Space Usage" $ADMIN
fi

set -vx is the shell debugger/verbose mode. Add that before you suspect line of code, then see the values that are substituted from CURRENT and THRESHOLD. Good luck. — shellter
– shellter, Commented Aug 4, 2014 at 22:19

konsolebox · Accepted Answer · 2014-08-04 22:23:57Z

3

Probably your script is in DOS format that the assignment includes \r The extra value appended to the number causes the error. Try converting it first with either of the following commands:

sed -i 's|\r||' script
dos2unix script

answered Aug 4, 2014 at 22:23

konsolebox

76.3k13 gold badges110 silver badges114 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Gordon Davisson Over a year ago

Looks like it to me. The error message : integer expression expected: [: 82 is a giveaway -- the : integer expression expected part should be at the end of the line, not the beginning, but since the erroneous string is 82\r, it winds up at the beginning instead.

John B · Accepted Answer · 2014-08-04 23:15:04Z

1

It looks like your CURRENT value is not being assigned to an integer from the command substitution output.

I'd recommend running df on the directory you want, then parse the output.

#!/bin/bash
[email protected]
THRESOLD=80
read -ra DF_OUT < <(df -H /dev/mapper/cvs-cvs 2>&1|tail -n 1)
if [[ ${DF_OUT[@]} != "df:"* ]]; then
    CURRENT=${DF_OUT[4]/\%/}
    if [ $CURRENT -ge $THRESOLD ]; then 
        echo "My CVS disk space usage is $CURRENT %" | mailx -s "Disk Space Usage" $ADMIN 
    fi
else
    echo -e "df encountered the following error:\n$DF_OUT"
fi

This first checks for an error on the df output before proceeding to parse the results for disk usage.

As others suggested, using -x with the script helps diagnose things.

edited Aug 4, 2014 at 23:15

answered Aug 4, 2014 at 22:37

John B

3,6661 gold badge19 silver badges22 bronze badges

2 Comments

John B Over a year ago

What was the error you got? Did you remove the \r characters as @konsolebox suggested in his solution? If your script works as is you can just use that, my solution was just a design difference to verify there weren't any errors from df output.

jimagic Over a year ago

your script is good but it did not work for me. konsolebox solution work for me. After you write the script, u have to execute sed -i 's|\r||' script.sh and it remove \r and execute fine. thanks for help. I upvoted your answer.

wwright · Accepted Answer · 2014-08-04 22:23:08Z

0

try

#!/bin/bash
[email protected]
let "THRESOLD=80"
declare -i CURRENT
let CURRENT=$(df -H | grep '/dev/sda1' | awk '{ print $5}' | cut -d'%' -f1)
if (($CURRENT >= $THRESOLD )) ; then
    echo "My CVS disk space usage is $CURRENT %" | mailx -s "Disk Space Usage" $ADMIN
fi

answered Aug 4, 2014 at 22:23

wwright

3642 silver badges8 bronze badges

4 Comments

jimagic Over a year ago

this is error i got --> sh Disk_Space_Emailer.sh ")syntax error: invalid arithmetic operator (error token is " ': not a valid identifierne 4: declare: `CURRENT ")syntax error: invalid arithmetic operator (error token is " Disk_Space_Emailer.sh: line 6: ((: >= : syntax error: operand expected (error token is ">= ")

wwright Over a year ago

what editor are you using to edit your scripts? What OS

jimagic Over a year ago

sublimetext, which editor do you recommend? Windows 7

wwright Over a year ago

? so, if editing on win7 where are you running the bash script? cygwin? Many windows editors use \n\r to terminate lines if you run a bash script with \r you will get un-expected errors and can spend many hours trying to debug. As mentioned above you want to either change settings on the editor to use linux \n line termination and not \n\r. sublimetext.com/docs/file-type-preferences search for defaultline you want 'unix' for bash scripts.

Collectives™ on Stack Overflow

integer expression expected error.

3 Answers 3

1 Comment

2 Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

2 Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related