Why SQL will only update the text boxes original text? ASP.Net

Question

so the problem I'm having is that on my button click it's supposed to update the database with the values in the text boxes. These are being read in on the page load. Having modified the code a bit to see what's going on, even if the content of the text box is changed, it submits the original text. I can't wrap my head around why. I need it to submit any changes to those text boxes. Any help or guidance appreciated.

protected void Page_Load(object sender, EventArgs e)
        {
                    SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["ConnectionString"].ConnectionString);
                    con.Open();

                    string checkic1 = "SELECT colum1 FROM table1 WHERE ID='1';";
                    SqlCommand c1Comm = new SqlCommand(checkic1, con);
                    string ic1 = c1Comm.ExecuteScalar().ToString();

                    con.Close();

                    c1TxtBox.Text = ic1;

        }

The example above is the same for c2TxtBox and c3TxtBox as well.

protected void Button1_Click(object sender, EventArgs e)
        {
                SqlConnection update = new   SqlConnection(ConfigurationManager.ConnectionStrings["ConnectionString"].ConnectionString);


                string addUpdate= "UPDATE table1 SET colum1 = @c1, colum2 = @c2, colum3 = @c3 WHERE ID='1';";
                SqlCommand comA = new SqlCommand(addUpdate, update);

                comA.Parameters.AddWithValue("@c1", c1TxtBox.Text);
                comA.Parameters.AddWithValue("@c2", c2TxtBox.Text);
                comA.Parameters.AddWithValue("@c3", c3TxtBox.Text);

                update.Open();

                comA.ExecuteNonQuery();

                update.Close();

                Response.Redirect("originalPage.aspx");
            }
        }

Every time the page loads (first time, or on postback, you are setting the value of C1txtBox. When you postback, PageLoad runs before Button1_Click so you can postback until the end of time and it will just keep updating the same value. Put your initial code that loads the values into if (!isPostBack) {} and, after updating, call the code to populate the box again (if you want) - or, ViewState will show the new value anyway. — Martin Smellworse
– Martin Smellworse, Commented Aug 7, 2014 at 8:43

Klaus Byskov Pedersen · Accepted Answer · 2014-08-07 08:41:01Z

1

The PageLoad function is called everytime you load the page, also when you submit the page by clicking your button. Therefore, the value of the textbox is overwritten before you try to update your database (because PageLoad is called before Button1_Click).

To overcome this, you could add a check to see if you are currently in a post back in your PageLoad method, like this:

protected void Page_Load(object sender, EventArgs e)
{
    if(!this.IsPostBack)
    {
        SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["ConnectionString"].ConnectionString);
        con.Open();

        string checkic1 = "SELECT colum1 FROM table1 WHERE ID='1';";
        SqlCommand c1Comm = new SqlCommand(checkic1, con);
        string ic1 = c1Comm.ExecuteScalar().ToString();

        con.Close();

        c1TxtBox.Text = ic1;
    }
}

answered Aug 7, 2014 at 8:41

Klaus Byskov Pedersen

122k31 gold badges192 silver badges223 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user3809554 Over a year ago

Thanks. This works. I had already tried (IsPostBack) but of course that does the reverse. Again thank you very much.

Collectives™ on Stack Overflow

Why SQL will only update the text boxes original text? ASP.Net

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related