Cannot implicitly convert string[][] to string[] in C#

Question

I'm getting this error in new keyword.

//Code:

  public static string[] SplitStrings(string inboundString, char splitChar)
        {
            if(inboundString.Contains(splitChar))
            {
                return new[] { inboundString.Split(splitChar) };
            }
        }

Since String.Split() method returns an array, you are creating an array of arrays. Just remove new [] and you should be fine. And you need to return another array (an empty array maybe) for your else part to prevent not all code paths return a value error. — Soner Gönül
– Soner Gönül, Commented Aug 7, 2014 at 14:12
Why do you use if(inboundString.Contains(splitChar)) at all? That costs CPU time for no added value. or do you want to return something else if inboundString doesn't contain the char? — Tim Schmelter
– Tim Schmelter, Commented Aug 7, 2014 at 14:14
In fact, why not just call inboundString.Split(splitChar) in the calling code? Does this function add any additional value? — Grax32
– Grax32, Commented Aug 7, 2014 at 14:18
@TimSchmelter: if it doesnt contains dont it throw an error? — A Coder
– A Coder, Commented Aug 7, 2014 at 14:20

Robert Levy · Accepted Answer · 2014-08-07 14:17:32Z

3

You don't need to create a new array the return from split works just fine.

public static string[] SplitStrings(string inboundString, char splitChar)
     {
        if(inboundString.Contains(splitChar))
        {
            return inboundString.Split(splitChar);
        }
        else 
        {
          return new string[] {};
        }
    }

edited Aug 7, 2014 at 14:17

Robert Levy

29.1k6 gold badges66 silver badges96 bronze badges

answered Aug 7, 2014 at 14:12

Hogan

70.7k10 gold badges83 silver badges119 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

nsgocev · Accepted Answer · 2014-08-07 14:21:08Z

2

Try it like this

        public static string[] SplitStrings(string inboundString, char splitChar)
        {               
             return inboundString.Split(splitChar);               
        }

String.Split itself returns a string[] so you don`t need to initialize a new one.

edited Aug 7, 2014 at 14:21

answered Aug 7, 2014 at 14:11

nsgocev

4,47030 silver badges37 bronze badges

5 Comments

A Coder Over a year ago

How can i handle the else part? any ideas??

Habib Over a year ago

@SanthoshKumar, it depends on what you want to return if the split character is not found in your string

nsgocev Over a year ago

@SanthoshKumar - Hogan`s idea of returning new string[] {}; will be good enough

A Coder Over a year ago

Will that return my value if split char is not found?

nsgocev Over a year ago

@SanthoshKumar - see the modified method. It will return the spllited string if splitChar is not empty. And it will return string[] {inboundString} if it is.

Collectives™ on Stack Overflow

Cannot implicitly convert string[][] to string[] in C#

2 Answers 2

Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related