Controller does not return the variable

Question

Form can be successfully submitted via ajax and the notification message can be displayed in jquery window ("Your name has been successfully changed!")but when I submit an empty form it doesn't return the message "fail". Could you please check my code and help me to find my mistake.

Controller:

$this->load->library('form_validation');
$this->load->model('my_model');   

$this->form_validation->set_rules('name','Name','required|trim|alpha|min_length[3]|xss_clean');

if($this->form_validation->run()) {
    $user_id = $this->session->userdata('user_id');
    $name = $this->input->post('name');
    if ($this->model_users->did_change_name($user_id, $name)) {
        $data = array(
            'message_ok' => "Your name has been successfully changed!"
        );
        echo json_encode($data);
    } else { 
        $data = array(
            'message' => 'fail'                   
        );
        echo json_encode($data);         
    }
}

Look at the request response in the browser's developer tools (CTRL+I, normally) - the PHP script may be error'ing without you knowing. — Mitya
– Mitya, Commented Aug 8, 2014 at 16:18
@NiceTry Please take some time to format your code correctly, i did it all for this question but remember is more fun to answer questions when the code is well indented! — Mathieu Dumoulin
– Mathieu Dumoulin, Commented Aug 8, 2014 at 16:23
Mathieu, thanks for formatting. Actually, I thought it was well formatted :) — NiceTry
– NiceTry, Commented Aug 8, 2014 at 16:29

EducateYourself · Accepted Answer · 2014-08-08 17:15:48Z

1

It's all about parentheses :) Try this way:

if($this->form_validation->run()) {
    $user_id = $this->session->userdata('user_id');
    $name = $this->input->post('name');
    if ($this->model_users->did_change_name($user_id, $name)) {
        $data = array(
            'message_ok' => "Your name has been successfully changed!"
        );
        echo json_encode($data);
    } 
}
else { 
        $data = array(
            'message' => 'fail'                   
        );
        echo json_encode($data);         
    }

answered Aug 8, 2014 at 17:15

EducateYourself

9792 gold badges14 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

NiceTry Over a year ago

Thank you very much:) I have just noticed that :)

Eliel · Accepted Answer · 2014-08-08 16:40:41Z

1

I haven't used CI in a good while, but from my understanding you're checking if the form was valid to run a series of events, such as a name change. But when the form validation returns false that's when one of your validation rules have failed, which it has.

if($this->form_validation->run()) {

    // your code

} else {

    $data = array(
        'message' => 'fail'                   
    );
    echo json_encode($data); 

}

answered Aug 8, 2014 at 16:40

Eliel

1646 bronze badges

3 Comments

NiceTry Over a year ago

when the validation forms returns false, controller should return the message "false" but it doesn't work

Eliel Over a year ago

Is nothing being returned, or does it return the successful message? If it's the latter the problem may be in your model.

NiceTry Over a year ago

when I submit a name, it changes the name successfully and returns the successful message. When I submit an empty form, it does not change the name and does not return the "fail" message.

Rick Calder · Accepted Answer · 2014-08-08 16:25:21Z

0

if($this->form_validation->run()==TRUE) {

Right now your code is always going to return the first argument because you aren't actually checking the result of the validation. It's currently equivalent to saying if(1)

https://ellislab.com/codeigniter/user-guide/libraries/form_validation.html

answered Aug 8, 2014 at 16:25

Rick Calder

18.8k3 gold badges27 silver badges41 bronze badges

1 Comment

NiceTry Over a year ago

I just tried in the way you described but nothing has been changed

Collectives™ on Stack Overflow

Controller does not return the variable

3 Answers 3

1 Comment

3 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related