Angular - function inside .factory

Question

I'm trying to run a function inside .factory to get posts, but I get an undefined error on my controller.

.factory('Portfolio', function($http, $log) {
  //get jsonp
    this.getPosts = function($scope) {
        $http.jsonp("http://test.uxco.co/json-test.php?callback=JSON_CALLBACK")
            .success(function(result) {
                $scope.posts = $scope.posts.concat(result);
                $scope.$broadcast("scroll.infiniteScrollComplete");
            });
    };
});


.controller('PortfolioCtrl', function($scope, Portfolio) {
    $scope.posts = [];
    Portfolio.getPosts($scope);

Thanks!

Fixed - having a doh moment! used .service instead

user3930160
– user3930160

2014-08-12 09:41:44 +00:00
Commented Aug 12, 2014 at 9:41 — user3930160
– user3930160, Commented Aug 12, 2014 at 9:41

Community · Accepted Answer · 2017-05-23 12:11:39Z

1

What you wrote is a service not a factory. so you either

change it to be .service instead of .factory.
or return the function inside an object like this

.factory('Portfolio', function($http, $log) {
    //get jsonp
    return {
        getPosts: function($scope) {
            $http.jsonp()
                .success(function(result) {
                    $scope.posts = $scope.posts.concat(result);
                    $scope.$broadcast("scroll.infiniteScrollComplete");
                });
        };
    }

});

check the difference between service and factory

edited May 23, 2017 at 12:11

CommunityBot

11 silver badge

answered Aug 12, 2014 at 9:42

ebram khalil

8,3197 gold badges45 silver badges60 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Rajesh Manilal · Accepted Answer · 2014-08-12 09:41:23Z

0

Use .factory code like this

.factory('Portfolio', function($http, $log) {
  //get jsonp
   return{
       getPosts: function($scope) {
        $http.jsonp("http://test.uxco.co/json-test.php?callback=JSON_CALLBACK")
        .success(function(result) {
            $scope.posts = $scope.posts.concat(result);
            $scope.$broadcast("scroll.infiniteScrollComplete");
        });
      };
    }
});

answered Aug 12, 2014 at 9:41

Rajesh Manilal

1,12410 silver badges20 bronze badges

Collectives™ on Stack Overflow

Angular - function inside .factory

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related