C Programming: error: expected ‘)’ before string constant [closed]

Question

Closed. This question is not reproducible or was caused by typos. It is not currently accepting answers.

This question was caused by a typo or a problem that can no longer be reproduced. While similar questions may be on-topic here, this one was resolved in a way less likely to help future readers.

Closed 11 years ago.

Improve this question

shell_command(char gcommand[100]) {
 char output[100];
 system(gcommand ">" output);

 return output;
}

Gives me
error: expected ‘)’ before string constant

I am not quite sure why this happens. Appriciate any help :)

What are you expecting system(gcommand ">" output); to do? It's simply wrong C. Fix that and I bet you that your problem will disappear — Avery
– Avery, Commented Aug 13, 2014 at 22:55
That isn't how you appends strings, see this answer on how to do that in C. stackoverflow.com/questions/5901181/c-string-append — Adam
– Adam, Commented Aug 13, 2014 at 22:56
I think he's trying to pipe into a C array from a system command? That doesn't work either. — Avery
– Avery, Commented Aug 13, 2014 at 22:57
output is a empty string at best and garbage at worst. What's the purpose of this array? — Fiddling Bits
– Fiddling Bits, Commented Aug 13, 2014 at 22:57

M.M · Accepted Answer · 2014-08-13 23:00:40Z

1

String literals can be concatenated like that, but string values cannot.

Further, it seems that you want the output of gcommand to end up in the buffer output.

It is not possible to do that with the system function. Assuming you are going to be executing in a POSIX-style shell where > is the shell redirection operator, the thing to the right of it must be a file name (or descriptor) in the shell.

To execute a command and capture the output, one way is to use the POSIX popen function:

FILE *pipe = popen(gcommand, "r");
char output[100] = { 0 };

if ( pipe )
{
    fgets(output, sizeof output, pipe);
    pclose(pipe);
}

return output;

answered Aug 13, 2014 at 23:00

M.M

143k26 gold badges223 silver badges400 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

C Programming: error: expected ‘)’ before string constant [closed]

1 Answer 1

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Linked

Related