Having issue in my if condition in my php code

Question

I want to do is when a user click the login button and the inputs are empty its will echo please enter email and password and if the user put email and password wrong it will echo incorrect email and password .

My problem is when i click the login button and the inputs are empty it echo both please enter email and password and incorrect email and password.

I want to echo please enter email and password if both email and password are empty only and if one of email or password is wrong it should echo incorrect email and password.

<?php

require 'encryption.php';
include_once('database.php');

$db = new Connection();
$db = $db->dbConnect();
$db->setAttribute(PDO::ATTR_EMULATE_PREPARES, false);

$email = $_POST['email'];
$pass = $_POST['password'];

$hash_cost_log2 = 8;
$hash_portable = FALSE;
$hasher = new PasswordHash($hash_cost_log2, $hash_portable);
$hash = '*';

$login = $db->prepare("SELECT user_password FROM tbl_user WHERE user_email= :email");
$login->bindParam(':email', $email, PDO::PARAM_STR);
$login->execute();
$hash = $login->fetchColumn();

    if(empty($email) && empty($pass)){
      echo "Please enter Email and Password";
    }
    if($hasher->CheckPassword($pass, $hash))
    {
        $st = $db->prepare("SELECT * from tbl_user WHERE user_email=? AND user_password=? AND user_active='1'");
        $st->bindParam(1, $email, PDO::PARAM_STR);
        $st->bindParam(2, $hash, PDO::PARAM_STR);
        $st->execute();

        if($st->rowCount() === 1){
            echo "1";
            exit;
        }
    }else{
        echo "Incorrect Email or Password";  
    }  
?>

if(empty($email) || empty($pass)) if one or the other is empty, it will trigger the error. — Funk Forty Niner
– Funk Forty Niner, Commented Aug 18, 2014 at 20:58
Either that, or check it on the client side with JS before passing it along to the PHP. — durbnpoisn
– durbnpoisn, Commented Aug 18, 2014 at 20:59

Arth · Accepted Answer · 2014-08-18 20:59:26Z

2

Change your second if to elseif.

answered Aug 18, 2014 at 20:59

Arth

13.1k5 gold badges43 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Marc B · Accepted Answer · 2014-08-18 21:08:44Z

0

Basically this:

if(empty($email) && empty($pass)){
    echo "Please enter Email and Password";
} else {
   if ($hasher->CheckPassword($pass, $hash))
         echo "works"
   } else {
         echo "doesn't work"
   }
}

answered Aug 18, 2014 at 21:08

Marc B

362k44 gold badges433 silver badges508 bronze badges

Collectives™ on Stack Overflow

Having issue in my if condition in my php code

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related