HTML Javascript Adding a var as an input value inside a for loop

Question

What I am doing is creating a table. And I am adding the values of this table using Javascript with html statements inside of a for loop. I know this may be hard to visualize so I have added a picture to show the radio buttons to the left hand side with the corresponding data on the rest of the row. I am trying to give the radio button the same value as my site id.

Here is an example of my table.

table ex

Here is my for loop:

   //html is the html code that will be converted from javascript to html, and the array for siteID is also declared before the for loop   
  

 //for loop to add the results to the array and also to the table
    for (var i = 0; i < results4.length; i++) {
      var object4 = results4[i];
      //the value of the site ID
      siteIDArray[i] = object4.get('SiteID');
     
      html += "<tr><td><center><br><input type='radio' onclick='alert(this.value)' 
                name='siteChosen' value='siteIDArray[i]'><center></td>";
      html += "<td><center><p>" + siteIDArray[i] + "</p></center></td>";
      ...  </tr>

 }

My problem is this just alerts the text siteIDArray[i], and when I tried to do value='"+siteIDArray[i]+"' and value="+siteIDArray[i]+" then the table doesn't load. I feel like I am really close. Am I just missing a small thing?

SOLVED using Elliot de Vries's answer below!

I don't have an error message but I can see that the table refuses to load . — MadsterMaddness
– MadsterMaddness, Commented Aug 22, 2014 at 20:53
Tip: You have an unclosed <center> tag in the first block. It's being opened twice. — emerson.marini
– emerson.marini, Commented Aug 22, 2014 at 20:57

user458962 · Accepted Answer · 2014-08-22 20:54:55Z

5

Right now the value of the "value" attribute is the string "siteIDArray[i]" and not its value. You will want to take it outside of the quotes:

html += "<tr><td><center><br><input type='radio' onclick='alert(this.value)' 
                name='siteChosen' value='" + siteIDArray[i] + "'><center></td>";

answered Aug 22, 2014 at 20:54

user458962

Sign up to request clarification or add additional context in comments.

7 Comments

Carlos Calla Over a year ago

taken from @undefined in the comments below the question

emerson.marini Over a year ago

Good spot, but I don't think this would stop the table to be rendered.

user458962 Over a year ago

Huh? What's @undefined?

Ram Over a year ago

Well, every programmer knows how to concatenate the strings :)

user458962 Over a year ago

If the table wasn't loading when you tried to take the array reference out of the quotes before swapping in my version of the line, I suspect it might have been just a misplaced or missing quote-- it's one of the reasons why building HTML with strings can be tricky.

|

Collectives™ on Stack Overflow

HTML Javascript Adding a var as an input value inside a for loop

1 Answer 1

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related