How to add many values to an array in PHP?

Question

My if statements are only adding one element to the arrays even though they should add several as several have identical tags.

<?php

include("mysqlconnect.php");

$select_query = "SELECT `ImagesId`,`ImagesPath`,`Tag` FROM `offerstbl` ORDER by `ImagesId` DESC";
$sql = mysql_query($select_query) or die(mysql_error());   

$data = array();

while($rows = mysql_fetch_array($sql,MYSQL_BOTH)){
    if ($rows['Tag'] == "sport"){
      $data['sport'] = array($rows['ImagesId'], $rows['ImagesPath'], $rows['Tag']);
    }
    if ($rows['Tag'] == "food"){
      $data['food'] = array($rows['ImagesId'], $rows['ImagesPath'], $rows['Tag']);
    }
   if ($rows['Tag'] == "clothes"){
      $data['clothes'] = array($rows['ImagesId'], $rows['ImagesPath'], $rows['Tag']);
    }
}

 echo json_encode($data);


 ?>

You don't need $data = array();, but that won't matter. What do you mean one element, one element as in one array? Please make clear. I'm guessing you need to do this: $data[]['sport'] = . You probably need a multidimensional array. — StackSlave
– StackSlave, Commented Aug 28, 2014 at 0:37

Barmar · Accepted Answer · 2014-08-28 00:38:23Z

You're overwriting the array element instead of pushing a new element onto the array. It should be:

$data['sport'][] = array($rows['ImagesId'], $rows['ImagesPath'], $rows['Tag']);

Also, your if seems unnecessary, since the keys of $data are identical to the tags. Just do:

$data[$rows['Tag']][] = array($rows['ImagesId'], $rows['ImagesPath'], $rows['Tag']);

I also recommend using associative arrays for the elements that you're adding, not indexed arrays:

$data[$rows['Tag']][] = array('ImagesId' => $rows['ImagesId'], 
                              'ImagesPath' => $rows['ImagesPath'], 
                              'Tag' => $rows['Tag']);

And since these keys are the same as the keys in $rows, you can simplify it to:

$data[$rows['Tag']][] = $rows;

You should also use MYSQL_ASSOC rather than MYSQL_BOTH, since you're never accessing the numeric keys of $rows.

Daryl Gill · Accepted Answer · 2014-08-28 00:47:07Z

0

You must change three lines from your code

$data['sport'] = array($rows['ImagesId'], $rows['ImagesPath'], $rows['Tag']);

to

$data['sport'][] = array($rows['ImagesId'], $rows['ImagesPath'], $rows['Tag']);

This

$data['food'] = array($rows['ImagesId'], $rows['ImagesPath'], $rows['Tag']);

to

$data['food'][] = array($rows['ImagesId'], $rows['ImagesPath'], $rows['Tag']);

This

$data['clothes'] = array($rows['ImagesId'], $rows['ImagesPath'], $rows['Tag']);

to

$data['clothes'][] = array($rows['ImagesId'], $rows['ImagesPath'], $rows['Tag']);

edited Aug 28, 2014 at 0:47

Daryl Gill

5,52511 gold badges41 silver badges71 bronze badges

answered Aug 28, 2014 at 0:43

user3349436

1515 bronze badges

Collectives™ on Stack Overflow

How to add many values to an array in PHP?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related