Why am I getting the Fatal error: Using $this when not in object context?

Question

I am trying to make a dynamic menu, but I keep getting the fatal error. Here is the code:

class Menu {

public $menu;

function __contstruct() {
    $this -> menu = array("Home" => "index.php",
    //"Eat" => array("Casual" => "casual.php", "Fine dining" => "fine_dining.php"),
    "Contact" => "contact.php");
}

public static function page_name() {
    return substr($_SERVER["SCRIPT_NAME"], strrpos($_SERVER["SCRIPT_NAME"], "/") + 1);
}

public static function menu_list() {
    $menu_list = "";
    foreach ($this->menu as $name => $url) {
        echo "<li ";
        if ($url == $this -> pagename()) {
            $menu_list .= "class='active'";
        }
        $menu_list .= "><a href='";
        $menu_list .= $url;
        $menu_list .= "'>" . $name . "</a></li>";
        return ($menu_list);
    }
}

}
?>

and calling it with

$nav = new Menu();
echo $nav->menu_list();

Please help me figure why it isn't working.

You've got multiple typos anyways. $this->pagename() does not exist. you've got $this->page_name() defined. — Marc B
– Marc B, Commented Sep 11, 2014 at 16:32
__contstruct() <= look closely. Zoom in if you have to. Better yet, look inside a dictionary. — Funk Forty Niner
– Funk Forty Niner, Commented Sep 11, 2014 at 16:33

Calvin Froedge · Accepted Answer · 2014-09-11 16:32:57Z

2

You can't use $this in a static method. $this is for objects. Use self to refer to the class a method is contained in when you don't have an instance.

Remove static from you method signature if you want to use in object context.

And more importantly, you spelled 'construct' incorrectly and typed 'pagename' instead of 'page_name'. This works:

<?php

class Menu {

public $menu;

function __construct() {
    $this -> menu = array("Home" => "index.php",
    //"Eat" => array("Casual" => "casual.php", "Fine dining" => "fine_dining.php"),
    "Contact" => "contact.php");
}

public function page_name() {
    return substr($_SERVER["SCRIPT_NAME"], strrpos($_SERVER["SCRIPT_NAME"], "/") + 1);
}

public function menu_list() {
    $menu_list = "";
    foreach ($this->menu as $name => $url) {
        echo "<li ";
        if ($url == $this -> page_name()) {
            $menu_list .= "class='active'";
        }
        $menu_list .= "><a href='";
        $menu_list .= $url;
        $menu_list .= "'>" . $name . "</a></li>";
        return ($menu_list);
    }
}

}

$nav = new Menu();
echo $nav->menu_list();

answered Sep 11, 2014 at 16:32

Calvin Froedge

16.4k17 gold badges58 silver badges62 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

JDDoesDev Over a year ago

Thank you so much. That works perfectly. I'm trying to get the handle of OOP and this is my project to do it with. I really appreciate the help.

Calvin Froedge Over a year ago

@user2367438 Please mark as accepted answer by clicking the checkmark. An upvote is always nice, too = )

JDDoesDev Over a year ago

Not enough rep for an upvote, but it will be accepted. Thanks again

Collectives™ on Stack Overflow

Why am I getting the Fatal error: Using $this when not in object context?

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related