PHP While Loop setting count ID

Question

I'm a little stuck with a piece of PHP I am working on, I need to set the href of a link to the same ID for the DIV below it, but its not setting them the same.

$x=1; 
     while ( $loop->have_posts() ) : $loop->the_post(); 
     if($color!='')
        {
            $out.='<'.$heading.' class="heading_accordion newHeadingColor">'.get_the_title().'</'.$heading.'>';
        }
     else
     {
                $out.='<dd class="accordion-navigation"><a href="#panel'.$x++.'">'.get_the_title().'</a>';
     }
                $out.= '<div id="panel'.$x++.'" class="content">'.get_the_content().'</div></dd>';

                endwhile; // end of the loop.

its doing

<a href="#panel1">link</a>
<div id="panel2">content</div>
<a href="#panel3">link</a>
<div id="panel4">content</div>
<a href="#panel5">link</a>
<div id="panel6">content</div>

and need something like

<a href="#panel1">link</a>
<div id="panel1">content</div>
<a href="#panel2">link</a>
<div id="panel2">content</div>
<a href="#panel3">link</a>
<div id="panel3">content</div>

What is wrong with the_ID();?

Ron van der Heijden
– Ron van der Heijden

2014-09-17 09:47:42 +00:00
Commented Sep 17, 2014 at 9:47 — Ron van der Heijden
– Ron van der Heijden, Commented Sep 17, 2014 at 9:47

Clément Malet · Accepted Answer · 2014-09-17 09:47:03Z

3

It's because you are incrementing $x twice : Once when you output the href, once when you output the id.

You could just remove the incrementation on the first output :

$out.='<dd class="accordion-navigation"><a href="#panel'.$x.'">'.get_the_title().'</a>';

And keep it in the second one :

$out.= '<div id="panel'.$x++.'" class="content">'.get_the_content().'</div></dd>';

answered Sep 17, 2014 at 9:47

Clément Malet

5,0903 gold badges32 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

James Brandon Over a year ago

Yea i tried that before but sets them all as 1 and never increases

Clément Malet Over a year ago

@JamesBrandon Leave the $x++ in the second part of course. Did you ?

Ram Sharma · Accepted Answer · 2014-09-17 09:46:54Z

1

try this

while ( $loop->have_posts() ) : $loop->the_post(); 
$x++;
     if($color!='')
        {
            $out.='<'.$heading.' class="heading_accordion newHeadingColor">'.get_the_title().'</'.$heading.'>';
        }
     else
     {
                $out.='<dd class="accordion-navigation"><a href="#panel'.$x.'">'.get_the_title().'</a>';
     }
                $out.= '<div id="panel'.$x.'" class="content">'.get_the_content().'</div></dd>';

            endwhile; // end of the loop.

answered Sep 17, 2014 at 9:46

Ram Sharma

8,8157 gold badges48 silver badges59 bronze badges

Comments

wbars · Accepted Answer · 2014-09-17 09:48:36Z

1

$x++

is equal to

$x = $x + 1

so you increment this 2 times in 1 iteration. Try to remove increment from one of this two segments.

answered Sep 17, 2014 at 9:48

wbars

5336 silver badges14 bronze badges

Comments

Macbernie · Accepted Answer · 2014-09-17 09:49:12Z

0

<?php
$x=1; 
while ( $loop->have_posts() ) : $loop->the_post();

if($color!='') {
    $out.='<'.$heading.' class="heading_accordion newHeadingColor">'.get_the_title().'</'.$heading.'>';
} else {
    $out.='<dd class="accordion-navigation"><a href="#panel'.$x.'">'.get_the_title().'</a>';
}
$out.= '<div id="panel'.$x.'" class="content">'.get_the_content().'</div></dd>';

$x++;
endwhile; // end of the loop.
?>

answered Sep 17, 2014 at 9:49

Macbernie

1,3236 gold badges26 silver badges48 bronze badges

Comments

Peter · Accepted Answer · 2014-09-17 09:55:20Z

0

You are doing the $x++ to early.

Just use $x to output the id and do $x++ after the if-else statement

answered Sep 17, 2014 at 9:55

Peter

9,1868 gold badges69 silver badges100 bronze badges

Collectives™ on Stack Overflow

PHP While Loop setting count ID

5 Answers 5

2 Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related