jQuery function in .click() etc

Question

So normally, I do it like this:

$('#selectRoom a').click( function(e) { 
e.preventDefault(); // To prevent the default behavior (following the link or adding # to URL)
// Do some function specific logic here
});

However, I would like to do it like this, to clean things up (and be able to reuse):

$('#selectRoom a').click( selectRoom );

function selectRoom () {
    e.preventDefault(); // To prevent the default behavior (following the link or adding # to URL)
    // Do some function specific logic here
}

The problem is, i cant pass the "e" event-handler to the function, then the selectRoom() function is called on load. i.e:

$('#selectRoom a').click( selectRoom(e) );

Can I fix this somehow?

Amy B · Accepted Answer · 2010-04-07 17:52:44Z

6

selectRoom() will be given the event:

function selectRoom(e)

That should work.

answered Apr 7, 2010 at 17:52

Amy B

18k12 gold badges67 silver badges83 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pointy · Accepted Answer · 2010-04-07 17:53:23Z

2

Declare it like this:

function selectRoom(e) {
  // now e will work
}

Do not do this:

$('#selectRoom a').click(selectRoom(e)); // WRONG DO NOT DO THIS

because that means, "Call the function selectRoom and then pass its return value to the "click" function in jQuery." You want to pass jQuery the name of the funcion, not the result of executing the function. Thus:

$('#selectRoom a').click(selectRoom);

answered Apr 7, 2010 at 17:53

Pointy

415k62 gold badges600 silver badges632 bronze badges

Comments

James Westgate · Accepted Answer · 2010-04-07 18:00:12Z

0

You can also return false from the function to prevent the event from continue to bubble.

answered Apr 7, 2010 at 18:00

James Westgate

11.5k8 gold badges66 silver badges69 bronze badges

Collectives™ on Stack Overflow

jQuery function in .click() etc

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related