String as parameter in java

Question

first of all I'm a beginner in java language , i wanted to test myself in a problem which is to encrypt a message given by the user , the class was as shown , unfortunately when i tried to use the class in Main class it gave me an Exception "in thread "main" java.lang.NullPointerException",

public class engToEnc {


    public String Message;
    public char []c = new char [Message.length()];



    public String readMessage(String pMessage)            
    {


        this.Message = pMessage;
        for(int i = 0 ; i < Message.length() ; i++)
        {
            c[i] = Message.charAt(i);
            c[i] += (char)27;
        }

        Message = String.copyValueOf(c);

        return Message;
    }

}

i tried to simplify the function to see the reason for the exception like that

public String readMessage(String pMessage)            
    {   
        this.Message = pMessage;

        return Message;
    }

but it also gave me the same exception so i did know that i have an issue with passing the string parameter, please help !

Message has no value assigned, it is just a null pointer. Message.length() will cause a NullPointerException. Try Message="some value". BTW, naming convention says to name attributed starting in lower case: this.message instead of this.Message. The latter will confuse everyone reading your code,. — Thomas Stets
– Thomas Stets, Commented Sep 20, 2014 at 13:44

paarandika · Accepted Answer · 2014-09-20 14:00:57Z

The problem is with your initiation of char array. When you create a new engToEnc object, Java creates variable Message for that particular object. And according to your code that is null(It's not initiated yet). Then Java tries to create the char array and create a new char arry of size of "Message". But the Message variable is null and it doesn't have property named length(). So it gives you NullPointer Exception. Try the code below. In there I initialize char array in the readMessage method after initiating Message variable.

    public class engToEnc {

    public String Message;
    public char[] c;

    public String readMessage(String pMessage) {

        this.Message = pMessage;
        c = new char[Message.length()];

        for (int i = 0; i < Message.length(); i++) {
            c[i] = Message.charAt(i);
            c[i] += (char) 27;
        }

        Message = String.copyValueOf(c);

        return Message;
    }

}

And please follow the naming conventions. Your code is pretty confusing to look at.

Jared Reeves · Accepted Answer · 2014-09-20 14:44:00Z

1

public class engToEnc { 
   public String message; // message not declared => messsage == null.
    //your are calling length() on message which are null. 
   public char []c = new char [message.length()]; 
    //instead do this:
   public String message;
   public char[] c;

   public String readMessage(String pMessage)            
   {
      //this.Message = pMessage;
      this.message = pMessage; // now message is declared, and we can call length().
      this.c = new char [message.length()];

      for(int i = 0 ; i < message.length() ; i++)
      {
         c[i] = message.charAt(i);
         c[i] += (char)27;
      }

      message = String.copyValueOf(c);

      return message;
   }
}

edited Sep 20, 2014 at 14:44

Jared Reeves

1,3902 gold badges15 silver badges29 bronze badges

answered Sep 20, 2014 at 13:56

MadsDue

473 bronze badges

Comments

Krayo · Accepted Answer · 2014-09-20 14:15:59Z

0

Here is the problem:

public String Message; // Message == null
public char []c = new char [Message.length()]; // NullPointerException

try this:

public String Message;
public char []c;

then:

public String readMessage(String pMessage) {
    this.Message = pMessage;
    c = new char [Message.length()];
    //...

edited Sep 20, 2014 at 14:15

answered Sep 20, 2014 at 13:48

Krayo

2,5104 gold badges29 silver badges47 bronze badges

Comments

Imran · Accepted Answer · 2014-09-20 15:36:14Z

0

Try the below code:

public class engToEnc {


public String Message;
public char []c ;



public String readMessage(String pMessage)            
{


    this.Message = pMessage;
    this.c = new char [Message.length()]
    for(int i = 0 ; i < Message.length() ; i++)
    {
        c[i] = Message.charAt(i);
        c[i] += (char)27;
    }

    Message = String.copyValueOf(c);

    return Message;
  }
}

edited Sep 20, 2014 at 15:36

answered Sep 20, 2014 at 13:51

Imran

4259 silver badges23 bronze badges

Comments

Kevin Panko · Accepted Answer · 2014-09-28 21:52:46Z

0

You have not allocated memory for Message data member

Do something like :-

Message = new String();

in your constructor and then inside readMessage allocate memory for c[].

edited Sep 28, 2014 at 21:52

Kevin Panko

8,61519 gold badges52 silver badges64 bronze badges

answered Sep 20, 2014 at 13:49

Shouvik Roy

546 bronze badges

Collectives™ on Stack Overflow

String as parameter in java

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related