Why is this code for adding buttons programatically does not work?

Question

I am trying to add some buttons to a Relative Layout programatically. I used some examples seen on StackOverflow, but for some reason I cannot understand, my code is not working: I want to have my buttons one above the other, but they end up being one on top of the other. Here is my layout file:

<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    android:id="@+id/mainLayout"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:paddingBottom="@dimen/activity_vertical_margin"
    android:paddingLeft="@dimen/activity_horizontal_margin"
    android:paddingRight="@dimen/activity_horizontal_margin"
    android:paddingTop="@dimen/activity_vertical_margin"
    tools:context="com.android.myApp.MainActivity" >

</RelativeLayout>

And here is my code:

    mLayout = (RelativeLayout) findViewById(R.id.mainLayout);
    RelativeLayout.LayoutParams lprams = new RelativeLayout.LayoutParams(RelativeLayout.LayoutParams.WRAP_CONTENT,
                                                                         RelativeLayout.LayoutParams.WRAP_CONTENT);

    Button btnTag = new Button(this);
    btnTag.setText("Button0");
    btnTag.setId(0);
    btnTag.setOnClickListener(mGlobalOnCLickListener);
    mLayout.addView(btnTag, lprams);
    lprams.addRule(RelativeLayout.BELOW, 0);

    btnTag = new Button(this);
    btnTag.setText("Button2");
    btnTag.setId(1);
    btnTag.setOnClickListener(mGlobalOnCLickListener);
    mLayout.addView(btnTag, lprams);

OK I could try that, but I still do not understand what is wrong with my code... — Alex
– Alex, Commented Sep 23, 2014 at 6:50
The problem is in this line lprams.addRule(RelativeLayout.BELOW, 0); — Piyush
– Piyush, Commented Sep 23, 2014 at 6:56

Asmita · Accepted Answer · 2014-09-23 06:59:33Z

1

Checkout this code....Hope this will help

mLayout = (RelativeLayout) findViewById(R.id.mainLayout); RelativeLayout.LayoutParams lprams = new RelativeLayout.LayoutParams(RelativeLayout.LayoutParams.WRAP_CONTENT, RelativeLayout.LayoutParams.WRAP_CONTENT);

Button btnTag = new Button(this);
btnTag.setText("Button0");
btnTag.setId(10);
btnTag.setOnClickListener(mGlobalOnCLickListener);
mLayout.addView(btnTag, lprams);


lprams = new RelativeLayout.LayoutParams(RelativeLayout.LayoutParams.WRAP_CONTENT,
                         RelativeLayout.LayoutParams.WRAP_CONTENT);

lprams.addRule(RelativeLayout.BELOW, 10);
btnTag = new Button(this);
btnTag.setText("Button2");
btnTag.setId(1);
btnTag.setOnClickListener(mGlobalOnCLickListener);
mLayout.addView(btnTag, lprams);

edited Sep 23, 2014 at 6:59

answered Sep 23, 2014 at 6:51

Asmita

463 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Alex Over a year ago

Nope, I still have the same issue.

Asmita Over a year ago

Can you check once with different ID for first button other that "0"?

Alex Over a year ago

Asmita, with the new version you posted It works fine. Seems the problem was indeed in the values. Do not know why 0 and 1 or 1 and 2 do not work. Thanks a lot!!

Collectives™ on Stack Overflow

Why is this code for adding buttons programatically does not work?

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related