javascript for loop dosn't loop through users created

Question

OK so I am making a register and login for a forum using javascript and localstorage. "School assignment" My problem is that when i created multiple user and store them in the localstorage, my for loop does not loop through them all, only the first one. So i can only access the forum with the first user i create.

function login ()  {
    if (checklogin()) {
        boxAlert.style.display = "block";
        boxAlert.innerHTML = "Welcome" + "";
        wallPanel.style.display = "block";
    } else {
        boxAlertfail.style.display = "block";
        boxAlertfail.innerHTML = "Go away, fail";
    }
}

function checklogin (){
    for  (var i = 0; i < aUsers.length; i++){
        if (aUsers[i].email == inputLoginMail.value && aUsers[i].password == inputLoginPassword.value){
            return true;
        }else{
            return false;
        }
    }
}

put in a console.log(aUsers) before you loop through them in checklogin — Callum Linington
– Callum Linington, Commented Sep 24, 2014 at 14:49
you're returning false after the first user fails your if so the for loop and function stop right there — FabioG
– FabioG, Commented Sep 24, 2014 at 14:49

jcera · Accepted Answer · 2014-09-24 14:54:07Z

1

how about:

function checklogin() {
    var validLogin = false;
    for (var i = 0; i < aUsers.length; i++) {
        if (aUsers[i].email == inputLoginMail.value 
            && aUsers[i].password == inputLoginPassword.value) {
            validLogin = true;
            break;
        }
    }
    return validLogin;
}

answered Sep 24, 2014 at 14:54

jcera

3452 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

mehulmpt · Accepted Answer · 2014-09-24 14:51:58Z

0

Ouch! You are returning false on very first attempt. The best way is to set a variable and then check for it.

function checklogin() {
        var z = 0;
        for (var i = 0; i < aUsers.length; i++) {
            if (aUsers[i].email == inputLoginMail.value && aUsers[i].password == inputLoginPassword.value) {
                z = 1;
                break;
            } else {
                z = 0;
            }

            if (z == 1) {
                // User logged in
            } else {
                // Fake user
            }
        }

answered Sep 24, 2014 at 14:51

mehulmpt

16.7k13 gold badges54 silver badges90 bronze badges

1 Comment

Rudi Over a year ago

Dosn't retrieve anything from the local storage when i try to login

Collectives™ on Stack Overflow

javascript for loop dosn't loop through users created

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related