Error Passing Array Variables into String

Question

This:

api_url = [1, 2, 3, 20, 21, 22, 23, 24, 25, 27]
api_url.each do |deal|
  response = HTTParty.get('http://api.pipedrive.com/v1/deals?filter_id=' + deal.to_s + '&start=0&sort_mode=asc&api_token=example')
  result = JSON.parse(response.body)
end

spits out:

[1, 2, 3, 20, 21, 22, 23, 24, 25, 27]

rather than the resulting JSON it's supposed to. When I replace loop with just one single call rather than an array, this very similar block afterwords works perfectly:

stage_deal_ids.each do |deal|
  response = HTTParty.get('http://api.pipedrive.com/v1/deals/' + deal.to_s + '/activities?start=0&api_token=example')
  result = JSON.parse(response.body)
end

What is your question?

sawa
– sawa

2014-10-03 16:30:08 +00:00
Commented Oct 3, 2014 at 16:30 — sawa
– sawa, Commented Oct 3, 2014 at 16:30

Maurício Linhares · Accepted Answer · 2014-10-06 23:35:06Z

2

You're looking for map not each:

api_url = [1, 2, 3, 20, 21, 22, 23, 24, 25, 27]
responses = api_url.map do |deal|
  response = HTTParty.get("http://api.pipedrive.com/v1/deals?filter_id=#{deal}&start=0&sort_mode=asc&api_token=example")
  JSON.parse(response.body)
end
puts responses.inspect

each just returns the original collection.

edited Oct 6, 2014 at 23:35

answered Oct 3, 2014 at 16:00

Maurício Linhares

40.4k15 gold badges127 silver badges160 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Jorge de los Santos Over a year ago

Also it's always better to use string interpolation which calls to_s by default.

Maurício Linhares Over a year ago

Updated the example for it.

Collectives™ on Stack Overflow

Error Passing Array Variables into String

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related