(Javascript) Script won't count just once, perhaps not recognizing variable?

Question

I'm sure this is a super easy fix and I just can't see it.. I have a play button and I only want it to write to database (inc playcount) only when it's clicked the first time.

Any idea why this doesn't work? This result counts every click, and if I do if countonce = 0 and declare at beginning as 0 it won't count any clicks. Am I misunderstanding javascript?

 <div id="left-05-play_">
 <script type="text/javascript">
 var currsong = 1;
 var playcountadd = document.getElementById('left-05-play_');
 playcountadd.onclick = function() {
 if (countonce != 1) {
 $.post( "php/songadd.php", { addsong: "1", } );
 var countonce = 1;
 } }
 </script>
 </div>

Thank-you for taking the time to read this question.

i would also disable the button in the onclick to indicate to the user that further clicks will be ignored even with internet working. — dandavis
– dandavis, Commented Oct 7, 2014 at 6:45

Curtis · Accepted Answer · 2014-10-07 06:36:42Z

1

This should do the trick.

var currsong = 1;
var songadded = false;
var playcountadd = document.getElementById('left-05-play_');

playcountadd.onclick = function() {
   if (!songadded) {
      $.post( "php/songadd.php", { addsong: "1", } );
      songadded = true;
   }
}

Changed countonce to songadded
Moved songadded out of onclick function
Changed songadded to boolean logic
Check whether songadded=false before proceeding with AJAX post

answered Oct 7, 2014 at 6:36

Curtis

104k69 gold badges280 silver badges359 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user4107871 Over a year ago

Thank-you so much curt! Worked beautifully of course and showed me something extremely valuable, can't thank-you enough!

Collectives™ on Stack Overflow

(Javascript) Script won't count just once, perhaps not recognizing variable?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related