how to add a variable within each loop

Question

In code:

<% @offer2.each do |offer|%>

<% @menuName=Menu.find_by_menu_item_name(offer.menuName_get)%>

<% @line_item.each do |line_item|%>

<%@validPrice=(@menuName.price)*(offer.disAmountOrPercentage)%>
<%end%>
<%end%>

I am new in rails.I want to add @validPrice += @validPrice but it's not working inside the loop or outside the loop.So how do I get the sum of this variable.

You should use snake_case for method names and variables.

Stefan
– Stefan

2014-10-07 10:33:52 +00:00
Commented Oct 7, 2014 at 10:33 — Stefan
– Stefan, Commented Oct 7, 2014 at 10:33

Gagan Gami · Accepted Answer · 2014-10-07 10:27:45Z

1

Try this:

<% @validPrice = 0 %> #initialized with zero

<% @offer2.each do |offer|%>  # 1st loop
 <% @menuName=Menu.find_by_menu_item_name(offer.menuName_get)%>
    <% @line_item.each do |line_item|%>  # 2nd loop
        <% @validPrice += (@menuName.price)*(offer.disAmountOrPercentage) %>
    <%end%>
 <%= @validPrice %>  # you can access and print @validprice out of 2nd loop here
<%end%>

answered Oct 7, 2014 at 10:27

Gagan Gami

10.3k1 gold badge32 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Debadatt · Accepted Answer · 2014-10-07 10:13:52Z

0

You should declare @validPrice= 0 on the top of the loop. So that it will not initialize repeatedly.

<% validPrice = 0 %>

<% @offer2.each do |offer|%>
  <% @menuName=Menu.find_by_menu_item_name(offer.menuName_get)%>
  <% @line_item.each do |line_item|%>
    <% validPrice += (@menuName.price)*(offer.disAmountOrPercentage) %> 
  <%end%> 
<%end%>

It will be better if you would make model method for this summations, rather to run in view pages.

answered Oct 7, 2014 at 10:13

Debadatt

6,0134 gold badges30 silver badges40 bronze badges

Comments

user2473975 · Accepted Answer · 2014-10-07 10:14:48Z

0

Try this

<% @offer2.each do |offer|%>
  <% @menuName=Menu.find_by_menu_item_name(offer.menuName_get)%>
  <% @line_item.each do |line_item|%>
    <%= validPrice = (@menuName.price)*(offer.disAmountOrPercentage) %> 
  <%end%> 
<%end%>

answered Oct 7, 2014 at 10:14

user2473975

Collectives™ on Stack Overflow

how to add a variable within each loop

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related