Passing GET variables using header in PHP

Question

I'm coding a "users-only" access for a site, and when the user is not logged in the dashboard is redirecting to the login page.

<?php
session_start();
$logged= $_SESSION['logged'];

if(!$logged){
    header("Location:http://www.someweb.com/system/login.php?logged_off=1");
}

?>

but the login page is not receiving the GET variable, can you please tell what am I doing wrong?

@pc-shooter, that is what exit does and it should be used with header/redirect. — The Alpha
– The Alpha, Commented Oct 8, 2014 at 19:42
@pc-shooter What websites do you maintain? I'd like to check them out... and turn on "ignore redirects" on my browser :) — sjagr
– sjagr, Commented Oct 8, 2014 at 19:42
@Dagon I've just read the link of Fred-ii (stackoverflow.com/a/2747803)..... Oh man, you were so right! This is what i like here, always learning. — Daniel Gasser
– Daniel Gasser, Commented Oct 8, 2014 at 19:50

score 3 · Accepted Answer · 2014-10-08 20:08:10Z

3

When using header location, you should call exit();

Why? Because the script's execution will not be terminated.

Parentheses () are optional, exit is a language construct not a function, and they actually are a bad idea (PHP has more work to do if they exist), just a terrible habit I have.

edited Oct 8, 2014 at 20:08

answered Oct 8, 2014 at 19:46

user557846

Sign up to request clarification or add additional context in comments.

9 Comments

user557846 Over a year ago

theres no new questions on S.O just new ways to ask(and answer)

Funk Forty Niner Over a year ago

Exactly. There's more than one way to ask a hunter/trapper on how to skin a waskiwee wabbit.

IMSoP Over a year ago

With you up until "or any header" - setting a header along with content is perfectly normal. e.g. header('Content-Type: application/json'); echo json_encode($something);

user557846 Over a year ago

fell free to edit answer to make it better - no really please do

Daniel Gasser Over a year ago

@Dagon +1 Maybe you should give me some lessons in PHP ;-)

|

Collectives™ on Stack Overflow

Passing GET variables using header in PHP

1 Answer 1

9 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

9 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related