angular code optimization about $http request

Question

my code :

    app.factory('requestData',function($http,$q){
       return {
        reqData:function(params,url){
            return $http.get(url,{"params":params}).then(function(data){
                return data.data
            });
        });

    requestData.reqData( {module:"channel"},'/channel' ).then(function(data){
            $scope.selectChannel = data.value;
        })
     .then(function(){

         requestData.reqData( {channel_id:$scope.selectChannel},'/channel').then(function(data){
             $scope.summary = data.summary;
         })

      })
     .then(function(){
        //use $scope.summary do something
      });

firstly,i must set "$scope.selectChannel" value by asynchronous,then i use "$scope.selectChannel" to request. there is another method to achieve?

There is a mismatch of brackets in your code. What is the opening bracket for the one you are closing at line 7? — Ali Motevallian
– Ali Motevallian, Commented Oct 15, 2014 at 4:03

Jazzy · Accepted Answer · 2014-10-15 03:42:27Z

1

Try something like this:

app.factory('RequestData',function($http,$q) {
    var RequestData = {
        // assuming params is an object
        reqData: function(params) {
            $http.post('/channel', params).then(function(response){
                RequestData.selectChannel = response.value;
            });
        }
    };

    return RequestData;
});

In your controller, inject RequestData as a dependency then set $scope.RequestData = RequestData then you will have access to RequestData.selectChannel in your views.

answered Oct 15, 2014 at 3:42

Jazzy

6,16911 gold badges55 silver badges75 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

soytian · Accepted Answer · 2014-10-15 05:00:59Z

1

I advice you to use $resource instead.

.factory("$$service", ["$resource", function ($resource) {
    return $resource('/channel',
        {
            module: "@module",
            channel_id: "@channel_id"
        };
}]);

and use in this way:

var service = new $$service();
service.$get({"module":"channel"})
    .then(function(data){
        return service.$get({"channel_id":data.value});
    })
    .then(function(data){
        $scope.summary = data;
    });

answered Oct 15, 2014 at 5:00

soytian

3182 silver badges3 bronze badges

Collectives™ on Stack Overflow

angular code optimization about $http request

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related