Sort Array with two loops Implementation

Question

I am new with Java. I try to do one of my assignment, but i can not figure out why my result still can not sort.

I have a prompt value(argument) 20 10 30 60 55, and i want to sort it. I wrote two loops, and converted prompt value (which is string) to Integer.

Result: ( It is not sorted)

20 10 30 60 55 Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 5 at question2.SortedArray.main(SortedArray.java:29)

This is the code i wrote:

int temp = 0;
    int array[] = null;
    int array2[];


    for(int i=0; i<args.length; i++){
        int a = Integer.parseInt(args[i]);
         array = new int[a];
        for(int j=0; j<args.length; j++){
            int b = Integer.parseInt(args[i]);
            array2 = new int[b];
            if(array[i]>array2[j])
                temp = array2[j];
                array2[j] = array[i];
                array[i] = temp;


        }
    }
    for (int i = 0; i < array.length; i++)
    {
              System.out.println(args[i].toString());
    }

I could understand this code i fould online below

int tempVar;
        for (int i = 0; i < numbers.length; i++)
        {
                 for(int j = 0; j < numbers.length; j++)
                 {
                         if(numbers[i] > numbers[j])
                         {
                         tempVar = numbers [j ];
                         numbers [j]= numbers [i];
                         numbers [i] = tempVar;
                         }
                 }
        }
        for (int i = 0; i < numbers.length; i++)
        {
                  System.out.print(numbers[i]+" ");
        }

}

Hi Chris, haven't go that far yet, because the class only teach us about Array yesterday. I wondering if i have use simple array with two loops. — Jake Huang
– Jake Huang, Commented Oct 23, 2014 at 17:04
Nice. If you want try and get ahead a little, you can read about Lists.. Here is the API for a List docs.oracle.com/javase/7/docs/api/java/util/List.html — Chris Bolton
– Chris Bolton, Commented Oct 23, 2014 at 17:09

Elliott Frisch · Accepted Answer · 2014-10-23 17:03:31Z

4

First, convert the String array of args into an int array of values. Then sort and display values. You've been sorting arrays (sized by your array int value), then printing the arguments (which you didn't sort). So, something like

int[] values = new int[args.length];
for (int i = 0; i < args.length; i++) {
    values[i] = Integer.parseInt(args[i]);
}
int temp = 0;
for (int i = 0; i < values.length - 1; i++) {
    for (int j = i + 1; j < values.length; j++) {
        if (values[i] > values[j]) {
            temp = values[j];
            values[j] = values[i];
            values[i] = temp;
        }
    }
}
System.out.println(Arrays.toString(values));

answered Oct 23, 2014 at 17:03

Elliott Frisch

202k20 gold badges166 silver badges265 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Stevenfowler16 · Accepted Answer · 2014-10-23 17:09:28Z

1

You need to initialize your array to hold your prompt values

int [] yourArray = {2,3,4 5,};

You don't need a second array to sort the values just a temporary int to hold the value that is being moved.

The statements below if needs to be enclose with { } otherwise all it will do is run to the first semicolon and then get out of the if.

Basically what the code you pasted in the second part is checking if element at the value i is greater than the value at element j. If the value is greater it swaps j with i.

for (int i = 0; i < numbers.length; i++)


  {
             for(int j = 0; j < numbers.length; j++)
             {
                     if(numbers[i] > numbers[j]) //if element at i is greater than element a j
                     {
                     tempVar = numbers [j ]; //store the number at element j in temp
                     numbers [j]= numbers [i];// set the number at element i to element j
                     numbers [i] = tempVar;// set the number at temp to element 
                     }
             } // does this for each element until no element i greater than j
    }

answered Oct 23, 2014 at 17:09

Stevenfowler16

1,0201 gold badge10 silver badges22 bronze badges

1 Comment

Jake Huang Over a year ago

Thank you, I really don't need a second array to sort

Nabin · Accepted Answer · 2014-10-23 17:14:26Z

1

Get the integers to an array at first.

 int[] yourArray = { 20, 10, 30, 60, 55 };
        for (int i = 0; i < yourArray.length; i++) {
            for (int j = 0; j < yourArray.length - 1; j++) {
                // swap
                if (yourArray[i] < yourArray[j]) {
                    int temp = yourArray[i];
                    yourArray[i] = yourArray[j];
                    yourArray[j] = temp;
                }
            }
        }
        for (int i : yourArray)
            System.out.println(i);

Output

10 20 30 55 60

edited Oct 23, 2014 at 17:14

answered Oct 23, 2014 at 16:58

Nabin

11.8k8 gold badges70 silver badges103 bronze badges

2 Comments

Jake Huang Over a year ago

Yes, Nabin. This is what i have been doing, but its not working. I know somewhere i did it wrong with converting from String to int.

Nabin Over a year ago

Aren't you getting values to array?

Collectives™ on Stack Overflow

Sort Array with two loops Implementation

3 Answers 3

Comments

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related