How to use ternary operator instead of if-else in PHP

Question

I’m trying to shorten my code using the ternary operator.

This is my original code:

if ($type = "recent") {
    $OrderType = "sid DESC";
} elseif ($type = "pop") {
    $OrderType = "counter DESC";
} else {
    $OrderType = "RAND()";
}

How can I use the ternary operator in my code instead of ifs/elses?

$OrderType = ($type = "recent") ? "sid DESC" : "counter DESC" ;

This is the code I tried, but have no idea how to add an “elseif part” to it.

you don't need to change your code, it's perfectly readable and fine. — SilentGhost
– SilentGhost, Commented Apr 24, 2010 at 16:21
possible duplicate of Which coding style you use for ternary operator? — outis
– outis, Commented Apr 1, 2012 at 5:33

Pascal MARTIN · Accepted Answer · 2010-04-24 16:07:27Z

This is called the ternary operator ;-)

You could use two of those :

$OrderType = ($type == 'recent' ? 'sid DESC' : ($type == 'pop' ? 'counter DESC' : 'RAND()'))

This can be read as :

if $type is 'recent'
then use 'sid DESC'
else
- if $type is 'pop'
- then use 'counter DESC'
- else use 'RAND()'

A couple of notes :

You must use == or === ; and not =
- The first two ones are comparison operators
- The last one is the assignment operator
It's best to use (), to make things easier to read
- And you shouldn't use too many ternary operators like that : it makes code a bit hard to understand, i think

And, as a reference about the ternary operator, quoting the Operators section of the PHP manual :

The third group is the ternary operator: ?:.
It should be used to select between two expressions depending on a third one, rather than to select two sentences or paths of execution.
Surrounding ternary expressions with parentheses is a very good idea.

Mauro · Accepted Answer · 2010-04-24 16:12:23Z

3

I'd suggest using a case statement instead. it makes it a little more readable but more maintainable for when you want to add extra options

switch ($type)
{
case "recent":
  $OrderType =  "sid DESC"; 
  break;
case "pop":
  $OrderType =  "counter DESC"; 
  break;
default:
   $OrderType =  "RAND()"; 
}

answered Apr 24, 2010 at 16:12

Mauro

4,5093 gold badges32 silver badges60 bronze badges

2 Comments

luminarious Over a year ago

The question is about ternary operators, but I agree, in this case, switch makes a lot more sense.

Mauro Over a year ago

Ah well, the question is to "shorten or better" - less lines doesnt always == better; I like ternary operators but sometimes they just arent the right thing to use.

Collectives™ on Stack Overflow

How to use ternary operator instead of if-else in PHP

2 Answers 2

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related