Laravel 4 - Undefined variable in select list using Eloquent

Question

I'm struggling to see why my select list is returning an error.

I have a nested foreach loop, the second loop which should display records by building_id. However it is this very id which it returns an undefined variable for ($building->id)

Is it the construction of the query which is at fault?

<select>
     @foreach (Building::orderBy('title')->get() as $building)
          <optgroup label="{{ $building->title }}"></optgroup>
           @foreach (Floor::whereIn('id', function($query){
                 $query->select('floor_id')
                   ->from('rooms')
                   ->where('building_id', $building->id)->distinct();
                   })->get() as $floor)
            <option value="{{ $floor->id }}">{{ $floor->description }}</option>
           @endforeach    
     @endforeach
</select>

Sn0opr · Accepted Answer · 2014-11-24 22:46:54Z

2

You are using a closure function which you have passed to Floor::whereIn So this closure function can't recognize external variables like the variable / object ($building) that you wanted to use in it. so you have to tell PHP to use this $bulding variable in this closure / anonymous function:

<select>
     @foreach (Building::orderBy('title')->get() as $building)
          <optgroup label="{{ $building->title }}"></optgroup>
           @foreach (Floor::whereIn('id', function($query) use ($building){
                 $query->select('floor_id')
                   ->from('rooms')
                   ->where('building_id', $building->id)->distinct();
                   })->get() as $floor)
            <option value="{{ $floor->id }}">{{ $floor->description }}</option>
           @endforeach    
     @endforeach
</select>

So now the function can reconize this variable :) Read more about it : http://php.net/manual/en/functions.anonymous.php

answered Nov 24, 2014 at 22:46

Sn0opr

1,0262 gold badges12 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Suba Over a year ago

Thank you for your informed answer. That's it working perfectly now.

alou · Accepted Answer · 2014-11-24 22:39:53Z

2

Try it like this

  ....
  @foreach (Floor::whereIn('id', function($query) use ($building){
  ...

answered Nov 24, 2014 at 22:39

alou

1,51214 silver badges17 bronze badges

Collectives™ on Stack Overflow

Laravel 4 - Undefined variable in select list using Eloquent

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related