Showing wrong output while reading from file in java

Question

Running this program shows the wrong output. My file "values.txt" contains 45678 and the output
after running the program is 00000.

import java.util.Scanner;
public class array{
    public static void main(String[] args)throws IOException
    {
        final int SIZE = 6;
        int[] numbers = new int[SIZE];
        int index = 0;
        File fl = new File("values.txt");
        Scanner ab = new Scanner(fl);
        while(ab.hasNext() && index < numbers.length)
        {
            numbers[index] = ab.nextInt();
            index++;
            System.out.println(numbers[index]);
        }
        ab.close();
    }
}

replace your while loop with while(ab.hasNext() && index<numbers.length) { numbers[index]=ab.nextInt(); System.out.println(numbers[index]); index++; } — jsjunkie
– jsjunkie, Commented Nov 26, 2014 at 8:18

StanislavL · Accepted Answer · 2014-11-26 08:16:33Z

4

You first assign to numbers[index] then increase index and output numbers[index] (for the next empty value).

Swap index++ and System.out calls.

answered Nov 26, 2014 at 8:16

StanislavL

57.5k9 gold badges75 silver badges100 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Bathsheba · Accepted Answer · 2014-11-26 08:16:46Z

4

Move index++ to after the System.out.println call.

At the moment you're always outputting an unassigned value of numbers. (In Java every element in an array of int is initialised to zero).

An alternative would be to discard index++; entirely and write System.out.println(numbers[index++]);. I personally find that clearer.

answered Nov 26, 2014 at 8:16

Bathsheba

235k35 gold badges376 silver badges504 bronze badges

Collectives™ on Stack Overflow

Showing wrong output while reading from file in java

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related