Insert into embedded document

Question

I have the following schema:

var UserSchema = new Schema({
  username: { type: String, required: true },
  password: { type: String, required: true },
  userType: { type: String, default: 'user'},
  quizzHistory: [{
    quizzName: String,
    quizzScore: Number
  }]
});

my goal is to change document into embedded quizzHistory or insert new one if not exists document in embedded quizzeHistory

I try to set document into embedded quizzHistory :

User.findOneAndUpdate({ _id: req.session.user['_id'], 'quizzHistory.quizzName': testName},
{ 
    '$set': {
        'quizzHistory.$.quizzName': testName,
        'quizzHistory.$.quizzScore': finalScore
    }
}, {upsert: true},
function(err, upd) {
  console.log("added");
})

code above works if there is document in quizzHistory with required _id and quizzHistory.quizzName,but don't pushed new one if there isn't any document.

Is there any way in Mongodb to change document into embedded collection or insert new one if not exists ?

pedrommuller · Accepted Answer · 2014-11-27 21:10:23Z

2

the reason is because you are using "find and update" you are not handling the condition when the row hasn't been found and create a new document, being said that you need manage the in a different way like

User.update({ _id: req.session.user['_id'], 'quizzHistory.quizzName': testName},
{ 
    '$push': {
        'quizzHistory.quizzName': testName,
        'quizzHistory.quizzScore': finalScore
    }
}, {upsert: true},
function(err, upd) {
  console.log("added");
})

edited Nov 27, 2014 at 21:10

answered Nov 27, 2014 at 20:40

pedrommuller

16.1k11 gold badges82 silver badges139 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

kaxi1993 Over a year ago

hi @jack.the.ripper thanks for your answer, there is no way to do it without condition?

pedrommuller Over a year ago

which condition? can you elaborate a little bit more?

kaxi1993 Over a year ago

i will do user.find and if it returns empty array i use $push otherwise $set

Levan Gulisashvili · Accepted Answer · 2014-11-28 13:15:39Z

1

this worked for me

User.update({ _id: req.session.user['_id'],'quizzHistory.quizzName':testName},
{ 
    $set: {
        "quizzHistory.$.quizzName":testName,
        "quizzHistory.$.quizzScore":finalScore
    }
},
function(err, upd) {
  if(!upd){
        User.update({ _id: req.session.user['_id']},
        { "$addToSet": { quizzHistory:  newScoreData }},function(err,data){
        });
  }
});

answered Nov 28, 2014 at 13:15

Levan Gulisashvili

1011 silver badge7 bronze badges

Comments

Lukasz Marek Sielski · Accepted Answer · 2014-11-28 14:36:31Z

1

If you want to benefit for all possible plugins and methods added to model and don't want to fight with actual Mongo queries you should first retrieve user object, then push new element to quizzHistory array and do save. Something like below (you need to align that code to your needs).

var entry = {
  quizzName : 'abc',
  quizzScore : 123
};

User.findOne({_id:id, function(err, object) {
  if(err) {
    return someErrorCallback();
  }
  var 
  object.quizzHistory.push(entry);
  object.save(function(err) {
    if(err) {
      return someErrorCallback();
    }
    someSuccessCallback();
  });
});

Updating directly may be efficient, but questions usage of mongoose.

Hope it makes sense.

answered Nov 28, 2014 at 14:36

Lukasz Marek Sielski

4243 silver badges7 bronze badges

Collectives™ on Stack Overflow

Insert into embedded document

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related