Best practice about JavaScript Promise

Question

return makeFirstPromise()
    .then(function(res1) {
       (...)
    })
    .then(function(res2) {
       (...)
    })
    .then(function(res3) {
        // **here I need to access res1**
    });

I would like to know if there is a best practice when I need to access to a previous promise result in a subsequent function of my promise chain.

I see two possible solutions:

var r1;
return makeFirstPromise()
    .then(function(res1) {
       r1 = res1;
       (...)
    })
    .then(function(res2) {
       (...)
    })
    .then(function(res3) {
        console.log(r1);
    });

or to nest the promises following the first but it visually breaks the chain sequence:

return makeFirstPromise()
    .then(function(res1) {
       (...)
       return secondPromise(res2)
           .then(function(res3) {
               console.log(res1);
           });
    });

Any idea?

exact duplicate of How do I access previous promise results in a .then() chain? — Bergi
– Bergi, Commented Jan 31, 2015 at 10:58

Clawish · Accepted Answer · 2014-12-05 16:06:37Z

3

Promise syntax is conceived to be used in the first way. The second syntax gets confusing very fast.
But don't forget to pass the result into the next promise.

var r1;
return makeFirstPromise()
    .then(function(res1) {
       r1 = res1;
       (...)
       return r1;
    })
    .then(function(r1) {
       (...)
    });

answered Dec 5, 2014 at 16:06

Clawish

2,9643 gold badges26 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Guid Over a year ago

The problem is my second promise already returns a value (res2).

Clawish Over a year ago

Make an array [] or object {} out of the results.

Guid Over a year ago

Could leads to a complicated code if I don't control the second promise (like a nodejs function) but I prefer this solution over the variable declaration solution. Thanks.

Benjamin Gruenbaum · Accepted Answer · 2014-12-05 23:57:54Z

2

Conceptually promises proxy values, the easiest way to use them with values is to use them as proxies. This is what they abstract:

var res1 = makeFirstPromise();
var res2 = res1.then(makeSecondPromise);
Promise.all([res1, res2]).spread(function(firstResult, secondResult){
    // access both here, no nesting or closure hacks required.
});

answered Dec 5, 2014 at 23:57

Benjamin Gruenbaum

278k90 gold badges524 silver badges524 bronze badges

2 Comments

Guid Over a year ago

nice idea but I have a chain of promises and it could be the 7th that needs a result from the 3th promise, for instance.

Benjamin Gruenbaum Over a year ago

Why would it matter? Also note that some promise implementations like Bluebird have a context you can pass around - look at Promise#bind at bluebird's API - that can also solve your problem.

Collectives™ on Stack Overflow

Best practice about JavaScript Promise

2 Answers 2

3 Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related