Creating Variable Table Name in SQL through Java?

Question

I am trying to make a variable Table name through Java.

My code is :

public void createTable(String tableName){

    try {
        Statement stmt = con.createStatement();
        stmt.executeUpdate("CREATE TABLE '"+tableName+"'" +
                   "(id INTEGER not NULL, " +
                   " username VARCHAR(255), " + 
                   " pass VARCHAR(255), " + 
                   " age INTEGER, " + 
                   " PRIMARY KEY ( id ))");

    }
    catch (SQLException e){
        e.printStackTrace();

    }


}

It gives me a syntax error saying:

Incorrect syntax near 'VariableTableNameIChose'.

Does anyone have any ideas?

tableName+"'" - Space is missing here.

Maroun
– Maroun

2014-12-07 13:27:36 +00:00
Commented Dec 7, 2014 at 13:27 — Maroun
– Maroun, Commented Dec 7, 2014 at 13:27

janos · Accepted Answer · 2014-12-07 13:32:03Z

2

It could be one of 2 things or the combination of both.

Maybe the single quotes around the table name are not valid in your database. So do like this:

    stmt.executeUpdate("CREATE TABLE "+tableName+" " +
               "(id INTEGER not NULL, " +
               " username VARCHAR(255), " + 
               " pass VARCHAR(255), " + 
               " age INTEGER, " + 
               " PRIMARY KEY ( id ))");

Or maybe you need a spaces between the table name and the ( following after:

    Statement stmt = con.createStatement();
    //                                              v this one was missing
    stmt.executeUpdate("CREATE TABLE '"+tableName+"' " +
               "(id INTEGER not NULL, " +
               " username VARCHAR(255), " + 
               " pass VARCHAR(255), " + 
               " age INTEGER, " + 
               " PRIMARY KEY ( id ))");

edited Dec 7, 2014 at 13:32

answered Dec 7, 2014 at 13:27

janos

126k31 gold badges242 silver badges253 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jbv2 Over a year ago

Thank you very much! This worked! (The first solution)

user330315 · Accepted Answer · 2014-12-07 13:32:24Z

1

The table name is an identifier. Identifiers do not use single quotes (in standard SQL).

"CREATE TABLE '"+tableName+"' "

Will result in

CREATE TABLE 'foobar'

which is invalid SQL. You need to remove the single quotes:

"CREATE TABLE "+tableName+" " + ...

As the table name is apparently a user input, you might actually want to use quoted identifiers (although this is in general a bad idea). Identifiers are quoted using double quotes in the SQL standard:

"CREATE TABLE \""+tableName+"\" " + ...

answered Dec 7, 2014 at 13:32

user330315

Collectives™ on Stack Overflow

Creating Variable Table Name in SQL through Java?

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related