Why is my foreach loop not looping through and populating array?

Question

I have a class that loops through a directory (5 images) and converts each image to base64 format and fills an array. However, it seems that the foreach loop only loops through once. There is 5 images in the directory, so it should have 5 iterations and the array should be 5 different images as well.

PHP

require_once "Results.php";
require_once "ImageHelper.php";

class IntroImageHelper {
    public static function GetImages()
    {
      $results = new Results();
      $results->IntroImages = Array();
      $dir = new DirectoryIterator("img/");
      $ImageExists = false;
      foreach($dir as $file)
      {
        if($file->isFile())
        {
          $ImageExists = $file->__toString();
          break;
        }
      }

      if($ImageExists)
      {
        $tempImage = new Results();
        $tempImage->ImageName = $ImageExists;
        $tempImage->ImageData = ImageHelperIntroSlides::DownloadImage($file);
        array_push($results->IntroImages, $tempImage);
      }

       return $results;
    }
}

Output:

{"IntroImages: [
    {"ImageName": "image.png",
     "ImageDate": "base64imagedata"
    }
  ]
}

You're not calling array_push() inside the loop.

Barmar
– Barmar

2014-12-08 22:13:51 +00:00
Commented Dec 8, 2014 at 22:13 — Barmar
– Barmar, Commented Dec 8, 2014 at 22:13

Scopey · Accepted Answer · 2014-12-08 22:10:57Z

4

Using a break statement will stop loops. You can use continue to skip the rest of the execution of the current iteration and go to to the next iteration, but in your case just omitting the break will fix your problem:

foreach($dir as $file) {
    if($file->isFile()) {
      $ImageExists = $file->__toString();
    }
}

In your case, a bunch of your code is outside of the loop when it should be inside:

foreach($dir as $file) {
    if($file->isFile()) {
      $ImageExists = $file->__toString();
    }
    if($ImageExists) {
        $tempImage = new Results();
        $tempImage->ImageName = $ImageExists;
        $tempImage->ImageData = ImageHelperIntroSlides::DownloadImage($file);
        array_push($results->IntroImages, $tempImage);
    }
}

But you can also combine those two statements:

foreach($dir as $file) {
    if($file->isFile()) {
        $tempImage = new Results();
        $tempImage->ImageName = $file->__toString();
        $tempImage->ImageData = ImageHelperIntroSlides::DownloadImage($file);
        array_push($results->IntroImages, $tempImage);
    }
}

answered Dec 8, 2014 at 22:10

Scopey

6,3291 gold badge24 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ryan Salmons Over a year ago

Thanks @Scopey! I didnt fully grasp the logic of a break. I assumed that it would temporarily stop, run the rest of the code, then come back and finish the loop.

meda · Accepted Answer · 2014-12-08 22:12:31Z

0

That's exactly what break will do, it will break out of the loop.

If you need to just flag a value, remove the break and let the iterations continue.

But in your case you did not need to, for a check change your loop to the following:

foreach($dir as $file)
{
    if($file->isFile())
    {
        $tempImage = new Results();
        $tempImage->ImageName = $file->__toString();
        $tempImage->ImageData = ImageHelperIntroSlides::DownloadImage($file);
        array_push($results->IntroImages, $tempImage);
    }
}

answered Dec 8, 2014 at 22:12

meda

45.5k14 gold badges97 silver badges123 bronze badges

Comments

unclemeat · Accepted Answer · 2015-04-28 03:43:31Z

0

Why do you have the break in the for loop? That will quit the loop...

edited Apr 28, 2015 at 3:43

unclemeat

5,2075 gold badges32 silver badges55 bronze badges

answered Dec 8, 2014 at 22:11

Traian

3,0031 gold badge28 silver badges35 bronze badges

2 Comments

Barmar Over a year ago

This is a question, not an answer.

Traian Over a year ago

it's a question-answer. It only goes once through because of the break. I was trying to point that out :)

Collectives™ on Stack Overflow

Why is my foreach loop not looping through and populating array?

3 Answers 3

1 Comment

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related