Return row with minimum value using Linq

Question

I have 2 classes like this:

public partial class Product
{
    public ICollection<ProductTerm> ProductTerms { get; set; }
    // More properties here
}

public partial class ProductTerm
{
    public short ID { get; set; }
    public short MinTermDuration { get; set; }
    // More properties here
}

As you will see, Product has a 1 to many relationship with ProductTerm.

I'm trying to return the entire ProductTerm with the Min MinTermDuration. I can get the result I want here but am returning the MinTermDuration - how do I return the whole ProductTerm?

    int GetMinTerm()
    {
        return ProductTerms.Min(t => t.MinTermDuration);
    }

See here

Vlad
– Vlad

2014-12-18 09:52:54 +00:00
Commented Dec 18, 2014 at 9:52 — Vlad
– Vlad, Commented Dec 18, 2014 at 9:52

Vsevolod Goloviznin · Accepted Answer · 2016-01-11 11:14:21Z

8

You can first order your products and then just take the first one on the top.

return ProductTerms.OrderBy(t => t.MinTermDuration).FirstOrDefault();

edited Jan 11, 2016 at 11:14

answered Dec 18, 2014 at 9:51

Vsevolod Goloviznin

12.4k1 gold badge53 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Thomas Levesque · Accepted Answer · 2014-12-18 10:08:10Z

3

You could use OrderBy(...).FirstOrDefault(), as suggested by Vsevolod Goloviznin; however this approach needs to sort the collection, which has a complexity of O(n log n)... The approach suggested by Selman22 is better, but it still enumerates the result twice (which could be an issue if the sequence is an Entity Framework or OData query).

A better option is to use a MinBy extension method that just loops over the collection once and returns the item that has the min value, with a complexity of O(n):

return ProductTerms.MinBy(t => t.MinTermDuration);

You can find such a method in Linq.Extras or in MoreLinq.

EDIT: the above is true if you're working with an in-memory collection (Linq to Objects), not if you're working with a database (using Entity Framework for instance). The DB knows how to find the item with the min value efficiently; using MinBy in this case would fetch all rows to examine them, so it would be very inefficient.

edited Dec 18, 2014 at 10:08

answered Dec 18, 2014 at 9:54

Thomas Levesque

294k73 gold badges639 silver badges769 bronze badges

3 Comments

dotnetnoob Over a year ago

I am using Entity Framework - what would the issue be?

Thomas Levesque Over a year ago

@dotnetnoob, EF queries implement IEnumerable<T>, so it should work fine. However, in this case it's better to use the OrderBy approach, because the DB can do it efficiently, whereas using MinBy would fetch all rows to examine them...

dotnetnoob Over a year ago

Ah, I see. This shouldn't be a problem - there are less than 100 products, each with around 5 terms. The data is retrieved .AsNoTracking and cached prior to any property being requested.

Selman Genç · Accepted Answer · 2014-12-18 10:04:20Z

1

Min returns the minimum value, not the item with the value. You can use First to get ProductTerm that has MinTermDuration:

ProductTerm GetMinTerm()
{
    var min = ProductTerms.Min(t => t.MinTermDuration);
    return ProductTerms.First(x => x.MinTermDuration == min);
}

Another alternative would be using MinBy method, it requires using a thir-party library but more straightforward:

ProductTerm GetMinTerm()
{
    return ProductTerms.MinBy(t => t.MinTermDuration);
}

edited Dec 18, 2014 at 10:04

answered Dec 18, 2014 at 9:52

Selman Genç

102k15 gold badges126 silver badges193 bronze badges

Collectives™ on Stack Overflow

Return row with minimum value using Linq

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related