Cloning an object doesn't work properly in C#

Question

I'm having trouble with copying an object.

I want to copy object1 and then make changes to object2 without changing object1.

// I'm cloning lower.Rebar object here
upper.Rebar = lower.Rebar.Clone();

// When I make changes to upper.Rebar, lower.Rebar gets changed too.
upper.Rebar.Polyline.Points.RemoveAll(p => p.Y < breaklevel);

// Here is how I'm cloning the lower.Rebar object
public ColumnElevationRebar Clone()
{
    var obj = new ColumnElevationRebar();

    obj.CanBeContinued = CanBeContinued;
    obj.CanBeSpliced = CanBeContinued;
    obj.ConnectionType = ConnectionType;
    obj.SpliceLength = SpliceLength;
    obj.Polyline = Polyline;

    return obj;
}

Definition of the class

public class ColumnElevationRebar
    {
        public ColumnElevationRebar Clone()
        {
            var obj = new ColumnElevationRebar();

            obj.CanBeContinued = CanBeContinued;
            obj.CanBeSpliced = CanBeContinued;
            obj.ConnectionType = ConnectionType;
            obj.SpliceLength = SpliceLength;
            obj.Polyline = Polyline;

            return obj;
        }

        private double splicelength;
        public double SpliceLength
        {
            get { return splicelength; }
            set { splicelength = Arithmetics.Ceiling(value, 100); }
        }

        public RebarConnectionType ConnectionType { get; set; }

        public bool CanBeSpliced;
        public bool CanBeContinued;

        public bool IsSelected;

        public Polyline Polyline { get; set; }

        public double Length
        {
            get { return Arithmetics.Ceiling(Polyline.Length, 100); }
        }
    }


public class Polyline
{
    public Polyline Clone()
    {
        var obj = new Polyline {Points = this.Points};
        return obj;
    }

    public Polyline()
    {
        Points = new List<_2DPoint>();
    }

    public List<_2DPoint> Points { get; set; }
}

Seems that Polyline should be cloned, not just assigned. — Dmitrii Bychenko
– Dmitrii Bychenko, Commented Dec 26, 2014 at 10:47
You mean I also need to define a Clone method for the polyline class? — Vahid
– Vahid, Commented Dec 26, 2014 at 10:48

IS4 · Accepted Answer · 2014-12-26 11:05:57Z

1

You are making only a shallow copy of the object. You should clone all non-value type objects, if you need a deep copy. Based on the names, I'm assuming only Polyline needs cloning:

public ColumnElevationRebar Clone()
{
    var obj = new ColumnElevationRebar();

    obj.CanBeContinued = CanBeContinued;
    obj.CanBeSpliced = CanBeContinued;
    obj.ConnectionType = ConnectionType;
    obj.SpliceLength = SpliceLength;
    obj.Polyline = Polyline.Clone();

    return obj;
}

Just define the Clone method in the Polyline object (I don't know the class).

Edit: You are making the same mistake in your Polyline class, you also need to clone the list:

public Polyline Clone()
{
    var obj = new Polyline {Points = new List<_2DPoint>(this.Points)};
    return obj;
}

edited Dec 26, 2014 at 11:05

answered Dec 26, 2014 at 10:49

IS4

13.5k2 gold badges60 silver badges94 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Vahid Over a year ago

I did now but it is not working. I added the Polyline class definition to the question.

Vahid Over a year ago

Thanks. It was really frustrating.

Mark Shevchenko · Accepted Answer · 2014-12-26 10:48:22Z

1

It seems Polyline is a class, not primitive type. If so, create Clone method for Polyline too and use it.

answered Dec 26, 2014 at 10:48

Mark Shevchenko

8,2651 gold badge28 silver badges31 bronze badges

6 Comments

Vahid Over a year ago

Should I use the same Cloning method I have used?

Mark Shevchenko Over a year ago

No. You need write new method. As far as I understand, Polyline aggregates an array (or a list) of Points, right? You need create copy of the array in Polyline.Clone method.

Vahid Over a year ago

One more question Mark, does this apply to enum types as well?

Mark Shevchenko Over a year ago

No. Enums like other primitive types (Int32, DateTime) can be just copied, not cloned. String is complex type, but it doesn't require cloning too, because it's read-only. Arrays, lists, stacks and other complex types must be cloned.

Mark Shevchenko Over a year ago

var obj = new Polyline {Points = new List<_2DPoint>(this.Points)}; Here will be created new list with same points.

|

Collectives™ on Stack Overflow

Cloning an object doesn't work properly in C#

2 Answers 2

2 Comments

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related