assignment from incompatible pointer type in c, for a pointer to struct

Question

I'm rather new to c, and I'm trying to implement a linked list. I wrote this:

struct List;
typedef struct List* ListRef;
struct List{
        void *data;
        ListRef next;
        ListRef last;
};

ListRef newList(void* headData);
[...]

ListRef append(ListRef list, void* data){

        ListRef newlist = newList(data)

        list->last->next = newList; //here I get a warning
        list->last = newList;  //here I get a warning

        return newList;
}

newList is compiled with no warnings. In the two lines with the comments I get:

warning: assignment from incompatible pointer type

What am I doing wrong?

Thank you!

Seriously consider a different name for your local automatic variable newList than the same name as the function newList(). Unless you're purposely trying to obfuscate code, it is a recipe for errors. — WhozCraig
– WhozCraig, Commented Dec 28, 2014 at 10:47

Spikatrix · Accepted Answer · 2014-12-28 10:49:29Z

2

Change

    list->last->next = newList; //here I get a warning
    list->last = newList;  //here I get a warning

    return newList;

to

    list->last->next = newlist; //here I get a warning
    list->last = newlist;  //here I get a warning

    return newlist;

Analysis:

You have a function named newList, which you have mixed-up with the instance of structure you created(newlist).

You sure dont code like you are new to C. :) Hope this helps

edited Dec 28, 2014 at 10:49

Spikatrix

20.3k7 gold badges45 silver badges85 bronze badges

answered Dec 28, 2014 at 10:44

Ganesh Kamath - 'Code Frenzy'

5,3513 gold badges48 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

assignment from incompatible pointer type in c, for a pointer to struct

1 Answer 1

Analysis:

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Analysis:

Comments

Your Answer

Sign up or log in

Post as a guest

Related