Validating users input between min and max using a function

Question

I'm trying to make a function that asks the user for a number in between whatever number is passed to the functions min and max, eg.(1,10) I can't seem to get it to work though, what am I missing/ doing wrong here?

function getProductChoice(min, max) {

    do {
        var productIndex = parseInt(prompt('Enter your product choice', '0'));
    } while( isNaN(productIndex) || productIndex <= max || productIndex >= min);

    getProductChoice(1,6);
 };

Your while condition should contain "bad" outcomes. For min and max it doesn't. Plus move function call outside of the function. Right now you have endless recursion. — PM 77-1
– PM 77-1, Commented Jan 5, 2015 at 4:39

NolanDC · Accepted Answer · 2015-01-05 04:47:42Z

1

I'm assuming you want to stop prompting when the given number satisifies the range. However, your current code does the opposite, continuing to run when the productIndex is less than the max or greater than the min. Try switching your max and min in the conditional.

In this example I've also pulled the getProductChoice() function call out of the function, as recursion is not necessary.

function getProductChoice(min, max) {
    do {
        var productIndex = parseInt(prompt('Enter your product choice', '0'));
    } while( isNaN(productIndex) || productIndex <= min || productIndex >= max);
 };
 getProductChoice(1,6);

answered Jan 5, 2015 at 4:47

NolanDC

1,0412 gold badges12 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Validating users input between min and max using a function

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related